[all-commits] [llvm/llvm-project] 759948: Reapply "Fix crash on switch conditions of non-int...

[Melanie Blower via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 759948467ea3181615d44d80f74ffeb260180fd0
      https://github.com/llvm/llvm-project/commit/759948467ea3181615d44d80f74ffeb260180fd0
  Author: Melanie Blower <melanie.blower at intel.com>
  Date:   2019-11-08 (Fri, 08 Nov 2019)

  Changed paths:
    M clang-tools-extra/test/clang-tidy/checkers/bugprone-string-integer-assignment.cpp
    M clang-tools-extra/test/clang-tidy/checkers/misc-unused-parameters.cpp
    M clang/lib/AST/Expr.cpp
    M clang/lib/Sema/SemaChecking.cpp
    M clang/test/SemaCXX/constant-expression-cxx2a.cpp
    M clang/test/SemaTemplate/dependent-names.cpp
    M clang/test/SemaTemplate/enum-argument.cpp
    M clang/test/SemaTemplate/member-access-expr.cpp
    A clang/test/SemaTemplate/non-integral-switch-cond.cpp

  Log Message:
  -----------
  Reapply "Fix crash on switch conditions of non-integer types in templates"

This patch reapplies commit 76945821b9cad3. The first version broke
buildbots due to clang-tidy test fails. The fails are because some
errors in templates are now diagnosed earlier (does not wait till
instantiation). I have modified the tests to add checks for these
diagnostics/prevent these diagnostics. There are no additional code
changes.

Summary of code changes:

Clang currently crashes for switch statements inside a template when the
condition is a non-integer field member because contextual implicit
conversion is skipped when parsing the condition. This conversion is
however later checked in an assert when the case statement is handled.
The conversion is skipped when parsing the condition because
the field member is set as type-dependent based on its containing class.
This patch sets the type dependency based on the field's type instead.

This patch fixes Bug 40982.

Reviewers: rnk, gribozavr2

Patch by: Elizabeth Andrews (eandrews)

Differential revision: https://reviews.llvm.org/D69950