[all-commits] [llvm/llvm-project] c62a9f: [lldb] Improve assert in GDBRemoteCommunicationRep...

[Jonas Devlieghere via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: c62a9f180c26e2fed012531caa581f0d736bfed9
      https://github.com/llvm/llvm-project/commit/c62a9f180c26e2fed012531caa581f0d736bfed9
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2019-11-07 (Thu, 07 Nov 2019)

  Changed paths:
    M lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationReplayServer.cpp

  Log Message:
  -----------
  [lldb] Improve assert in GDBRemoteCommunicationReplayServer

While investigating an issue where a different packet was sent during
replay I noticed how annoying it is that the existing assert doesn't
specify what packet is actually different. It's printed to the log, but
enabling logging has the potential to change LLDB's behavior. The same
is true when debugging LLDB while it's replaying the reproducer.

I replaced the assert with a printf of the unexpected packet followed by
a fatal_error wrapped in ifndef NDEBUG. The behavior is the same as the
previous assert, just with more/better context.