[all-commits] [llvm/llvm-project] ff9d73: crashlog.py: Improve regular expressions

adrian-prantl via All-commits all-commits at lists.llvm.org
Thu Nov 7 10:52:27 PST 2019


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: ff9d732887385e6f3e516769419dd64b406d81d8
      https://github.com/llvm/llvm-project/commit/ff9d732887385e6f3e516769419dd64b406d81d8
  Author: Adrian Prantl <aprantl at apple.com>
  Date:   2019-11-07 (Thu, 07 Nov 2019)

  Changed paths:
    M lldb/examples/python/crashlog.py
    M lldb/test/Shell/Python/crashlog.test

  Log Message:
  -----------
  crashlog.py: Improve regular expressions

This is yet another change to the regular expressions in crashlog.py
that fix a few edge cases, and attempt to improve the readability
quite a bit in the process. My last change to support spaces in
filenames introduced a bug that caused the version/archspec field to
be parsed as part of the image name.

For example, in "0x1111111 - 0x22222 +MyApp Pro arm64 <01234>", the
name of the image was recognized as "MyApp Pro arm64" instead of
"MyApp Pro" with a "version" of arm64.

The bugfix makes the space following an optional field mandatory
*inside* the optional group.

rdar://problem/56883435

Differential Revision: https://reviews.llvm.org/D69871




More information about the All-commits mailing list