[all-commits] [llvm/llvm-project] 9f9f42: TableGen: Remove assert that pattern results match...

Matt Arsenault via All-commits all-commits at lists.llvm.org
Wed Nov 6 16:13:41 PST 2019


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 9f9f42dbc5f54bbee6785a62acc8cd7e5ed12ea5
      https://github.com/llvm/llvm-project/commit/9f9f42dbc5f54bbee6785a62acc8cd7e5ed12ea5
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2019-11-06 (Wed, 06 Nov 2019)

  Changed paths:
    M llvm/utils/TableGen/DAGISelMatcherGen.cpp

  Log Message:
  -----------
  TableGen: Remove assert that pattern results match input number

AMDGPU has some atomic instructions that do not return the previous
result, and can only be selected if there are no uses. The source
pattern will only match if the use is empty, so it should be safe to
discard the result.


  Commit: e16a71382d689c39561e94b13af2feb4bf1b15cc
      https://github.com/llvm/llvm-project/commit/e16a71382d689c39561e94b13af2feb4bf1b15cc
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2019-11-06 (Wed, 06 Nov 2019)

  Changed paths:
    M llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp
    M llvm/lib/Target/AMDGPU/AMDGPUISelLowering.h
    M llvm/lib/Target/AMDGPU/FLATInstructions.td
    M llvm/lib/Target/AMDGPU/SIISelLowering.cpp
    M llvm/lib/Target/AMDGPU/SIInstrInfo.td
    A llvm/test/CodeGen/AMDGPU/global-atomics-fp.ll
    M llvm/test/Transforms/AtomicExpand/AMDGPU/expand-atomic-rmw-fadd.ll

  Log Message:
  -----------
  AMDGPU: Select global atomicrmw fadd

This only works if there is no use of the return value.


Compare: https://github.com/llvm/llvm-project/compare/e511c4b0dff1...e16a71382d68


More information about the All-commits mailing list