[all-commits] [llvm/llvm-project] 6cecd3: [lit] Protect full test suite from FILECHECK_OPTS

[Joel E. Denny via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 6cecd3c3dbef48eca6c4cf2dcc2df3290ab91488
      https://github.com/llvm/llvm-project/commit/6cecd3c3dbef48eca6c4cf2dcc2df3290ab91488
  Author: Joel E. Denny <jdenny.ornl at gmail.com>
  Date:   2019-11-06 (Wed, 06 Nov 2019)

  Changed paths:
    M llvm/utils/lit/tests/lit.cfg
    M llvm/utils/lit/tests/shtest-run-at-line.py

  Log Message:
  -----------
  [lit] Protect full test suite from FILECHECK_OPTS

lit's test suite calls lit multiple times for various sample test
suites.  `FILECHECK_OPTS` is safe for FileCheck calls in lit's test
suite.  It's not safe for FileCheck calls in the sample test suites,
whose output affects the results of lit's test suite.

Without this patch, only one such sample test suite is protected from
`FILECHECK_OPTS`, and currently `shtest-shell.py` breaks with
`FILECHECK_OPTS=-vv`.  Moreover, it's hard to predict the future,
especially false passes.  Thus, this patch protects all existing and
future sample test suites from `FILECHECK_OPTS` (and the deprecated
`FILECHECK_DUMP_INPUT_ON_FAILURE`).

Reviewed By: probinson

Differential Revision: https://reviews.llvm.org/D65156