[all-commits] [llvm/llvm-project] 9357b5: Revert and patch "[Python] Remove readline module"

serge-sans-paille via All-commits all-commits at lists.llvm.org
Tue Nov 5 02:39:28 PST 2019


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 9357b5d08497326a1895cab6c1d712bf12a34519
      https://github.com/llvm/llvm-project/commit/9357b5d08497326a1895cab6c1d712bf12a34519
  Author: serge-sans-paille <sguelton at redhat.com>
  Date:   2019-11-05 (Tue, 05 Nov 2019)

  Changed paths:
    M lldb/source/Plugins/ScriptInterpreter/Python/CMakeLists.txt
    A lldb/source/Plugins/ScriptInterpreter/Python/PythonReadline.cpp
    A lldb/source/Plugins/ScriptInterpreter/Python/PythonReadline.h
    M lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp

  Log Message:
  -----------
  Revert and patch "[Python] Remove readline module"

Fix https://bugs.llvm.org/show_bug.cgi?id=43830 while avoiding polluting the
global Python namespace.

This both reverts r357277 to rebundle a version of Python's readline module
based on libedit.

However, this patch also provides two improvements over the previous
implementation:

1. use PyMem_RawMalloc instead of PyMem_Malloc, as expected by PyOS_Readline
   (prevents to segfault upon exit of interactive session)
2. patch the readline module upon embedded interpreter loading, instead of
   patching it globally, which should prevent any side effect on other
   modules/packages
3. only activate the patched module if libedit is actually linked in lldb

Differential Revision: https://reviews.llvm.org/D69793




More information about the All-commits mailing list