[all-commits] [llvm/llvm-project] 28cf96: MemoryRegion: Print "don't know" permission values...

[Pavel Labath via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 28cf9698abd39221001ace885a7d1c1f488b967c
      https://github.com/llvm/llvm-project/commit/28cf9698abd39221001ace885a7d1c1f488b967c
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2019-11-05 (Tue, 05 Nov 2019)

  Changed paths:
    M lldb/include/lldb/Target/MemoryRegionInfo.h
    M lldb/source/Commands/CommandObjectMemory.cpp
    M lldb/source/Target/MemoryRegionInfo.cpp
    M lldb/test/Shell/Minidump/memory-region-from-module.yaml

  Log Message:
  -----------
  MemoryRegion: Print "don't know" permission values as such

Summary:
The permissions in a memory region have ternary states (yes, no, don't
know), but the memory region command only prints in binary, treating
"don't know" as "yes", which is particularly confusing as for instance
the unwinder will treat an unknown value as "no".

This patch makes is so that we distinguish all three states when
printing the values, using "?" to indicate the lack of information. It
is implemented via a special argument to the format provider for the
OptionalBool enumeration.

Reviewers: clayborg, jingham

Subscribers: lldb-commits

Differential Revision: https://reviews.llvm.org/D69106