[all-commits] [llvm/llvm-project] 25b486: [lldb][NFC] Remove unused ExpressionParser::Parse

[Raphael Isemann via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 25b486ac4f335fc51240888d6cfbc9c3c211536a
      https://github.com/llvm/llvm-project/commit/25b486ac4f335fc51240888d6cfbc9c3c211536a
  Author: Raphael Isemann <teemperor at gmail.com>
  Date:   2019-11-04 (Mon, 04 Nov 2019)

  Changed paths:
    M lldb/include/lldb/Expression/ExpressionParser.h
    M lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.h
    M lldb/source/Plugins/ExpressionParser/Clang/ClangFunctionCaller.cpp

  Log Message:
  -----------
  [lldb][NFC] Remove unused ExpressionParser::Parse

Summary:
This function is only used internally by ClangExpressionParser. By putting it in the ExpressionParser class all languages
that implement ExpressionParser::Parse have to share the same signature (which forces us in downstream to add
swift-specific arguments to ExpressionParser::Parse which then propagate to ClangExpressionParser and so on).

Reviewers: davide

Subscribers: JDevlieghere, lldb-commits

Tags: #upstreaming_lldb_s_downstream_patches, #lldb

Differential Revision: https://reviews.llvm.org/D69710