[all-commits] [llvm/llvm-project] 1739c7: Reapply [LLDB] [test] Use %clang_cl instead of bui...

[Martin Storsjö via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 1739c7c10c42748c278b0ea194e32bbfdd04fb98
      https://github.com/llvm/llvm-project/commit/1739c7c10c42748c278b0ea194e32bbfdd04fb98
  Author: Martin Storsjö <martin at martin.st>
  Date:   2019-11-01 (Fri, 01 Nov 2019)

  Changed paths:
    M lldb/test/Shell/SymbolFile/NativePDB/disassembly.cpp
    M lldb/test/Shell/SymbolFile/NativePDB/function-types-calling-conv.cpp

  Log Message:
  -----------
  Reapply [LLDB] [test] Use %clang_cl instead of build.py in a few tests

This allows explicitly specifying the intended target architecture,
for tests that aren't supposed to be executed, and that don't
require MSVC headers or libraries to be available.

(These tests already implicitly assumed to be built for x86; one
didn't specify anything, assuming x86_64, while the other specified
--arch=32, which only picks the 32 bit variant of the default target
architecture).

Join two comment lines in disassembly.cpp, to keep row numbers
checked in the test unchanged.

This fixes running check-lldb on arm linux.

Previously when this was applied (in 95980409e6), it broke
macos buildbots, as they added "-isysroot <path>" to all %clang*
substitutions, and clang-cl didn't support that.

Reapplying it without further changes to this patch, after D69619
(9c73925226), because now, such extra parameters are added to
%clang_host*, but not to plain %clang_cl.

Differential Revision: https://reviews.llvm.org/D69031