[all-commits] [llvm/llvm-project] 764c84: [nfc][libomptarget] Reorganise support header

Jon Chesterfield via All-commits all-commits at lists.llvm.org
Thu Oct 31 10:15:15 PDT 2019


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 764c8420e4b8fc11a9fa94d00f4ee617aa754cb2
      https://github.com/llvm/llvm-project/commit/764c8420e4b8fc11a9fa94d00f4ee617aa754cb2
  Author: JonChesterfield <jonathanchesterfield at gmail.com>
  Date:   2019-10-31 (Thu, 31 Oct 2019)

  Changed paths:
    M openmp/libomptarget/deviceRTLs/nvptx/CMakeLists.txt
    M openmp/libomptarget/deviceRTLs/nvptx/src/omptarget-nvptx.h
    A openmp/libomptarget/deviceRTLs/nvptx/src/support.cu
    M openmp/libomptarget/deviceRTLs/nvptx/src/support.h
    R openmp/libomptarget/deviceRTLs/nvptx/src/supporti.h
    M openmp/libomptarget/deviceRTLs/nvptx/src/target_impl.h
    M openmp/libomptarget/deviceRTLs/nvptx/unity.cu

  Log Message:
  -----------
  [nfc][libomptarget] Reorganise support header

Summary:
[nfc][libomptarget] Reorganise support header

All functions defined in support implementation are now declared in support.h
Reordered functions in support implementation to match the sequence in support.h
Added include guards to support.h
Added #include interface to support.h to provide kmp_Ident declaration
Move supporti.h to support.cu and s/INLINE/EXTERN/g
Add remaining includes to support.cu

A minor side effect is to change the name mangling of the support functions to
extern "C". If this matters another macro along the lines of INLINE/EXTERN
can be added - perhaps DEVICE as that's the obvious implementation.

Reviewers: jdoerfert, ABataev, grokos

Reviewed By: jdoerfert

Subscribers: mgorny, jfb, openmp-commits

Tags: #openmp

Differential Revision: https://reviews.llvm.org/D69652




More information about the All-commits mailing list