[all-commits] [llvm/llvm-project] 27cb35: [llvm-objcopy] --add-symbol: address post-commit r...

[Fangrui Song via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 27cb352fd27668519f25ab8d5717173fc3ff2235
      https://github.com/llvm/llvm-project/commit/27cb352fd27668519f25ab8d5717173fc3ff2235
  Author: Fangrui Song <maskray at google.com>
  Date:   2019-10-31 (Thu, 31 Oct 2019)

  Changed paths:
    M llvm/test/tools/llvm-objcopy/ELF/add-symbol-no-symtab.test
    M llvm/tools/llvm-objcopy/ELF/Object.cpp

  Log Message:
  -----------
  [llvm-objcopy] --add-symbol: address post-commit reviews of D69093

* Improve comments.
* Reorder the assignment to Obj.SectionNames before the symbol table
  creation code. Add a test.

Reviewed By: grimar

Differential Revision: https://reviews.llvm.org/D69526