[all-commits] [llvm/llvm-project] 83a55c: minidump: Rename some architecture constants

Pavel Labath via All-commits all-commits at lists.llvm.org
Wed Oct 30 06:47:19 PDT 2019


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 83a55c6a575806eec78062dfe128c095c26ab5e2
      https://github.com/llvm/llvm-project/commit/83a55c6a575806eec78062dfe128c095c26ab5e2
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2019-10-30 (Wed, 30 Oct 2019)

  Changed paths:
    M lldb/packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/arm64-macos.yaml
    M lldb/packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/regions-linux-map.yaml
    M lldb/source/Plugins/Process/minidump/MinidumpParser.cpp
    M lldb/test/Shell/Minidump/dump-all.test
    M lldb/test/Shell/Minidump/fb-dump.test
    M llvm/include/llvm/BinaryFormat/MinidumpConstants.def
    M llvm/lib/ObjectYAML/MinidumpYAML.cpp
    M llvm/test/tools/obj2yaml/basic-minidump.yaml
    M llvm/unittests/ObjectYAML/MinidumpYAMLTest.cpp

  Log Message:
  -----------
  minidump: Rename some architecture constants

The architecture enum contains two kinds of contstants: the "official" ones
defined by Microsoft, and unofficial constants added by breakpad to cover the
architectures not described by the first ones.

Up until now, there was no big need to differentiate between the two. However,
now that Microsoft has defined
https://docs.microsoft.com/en-us/windows/win32/api/sysinfoapi/ns-sysinfoapi-system_info
a constant for ARM64, we have a name clash.

This patch renames all breakpad-defined constants with to include the prefix
"BP_". This frees up the name "ARM64", which I'll re-introduce with the new
"official" value in a follow-up patch.

Reviewers: amccarth, clayborg

Subscribers: lldb-commits, llvm-commits

Differential Revision: https://reviews.llvm.org/D69285




More information about the All-commits mailing list