[all-commits] [llvm/llvm-project] 09feea: [IR] move/change null-check to assert

RotateRight via All-commits all-commits at lists.llvm.org
Tue Oct 29 06:28:58 PDT 2019


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 09feea972d0f2c7b4f16719f3c70ac0795770330
      https://github.com/llvm/llvm-project/commit/09feea972d0f2c7b4f16719f3c70ac0795770330
  Author: Sanjay Patel <spatel at rotateright.com>
  Date:   2019-10-29 (Tue, 29 Oct 2019)

  Changed paths:
    M llvm/lib/IR/Constants.cpp

  Log Message:
  -----------
  [IR] move/change null-check to assert

This should trigger a dereference before null-check warning,
but I don't see it when building with clang. In any case, the
current and known future users of this helper require non-null
args, so I'm converting the 'if' to an assert.




More information about the All-commits mailing list