[all-commits] [llvm/llvm-project] cc0b96: [LLD][ThinLTO] Handle GUID collision in import glo...

[Teresa Johnson via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: cc0b9647b76178bc3869bbfff80535ad86366472
      https://github.com/llvm/llvm-project/commit/cc0b9647b76178bc3869bbfff80535ad86366472
  Author: Teresa Johnson <tejohnson at google.com>
  Date:   2019-10-25 (Fri, 25 Oct 2019)

  Changed paths:
    M llvm/lib/Transforms/Utils/FunctionImportUtils.cpp
    A llvm/test/ThinLTO/X86/Inputs/guid_collision.ll
    A llvm/test/ThinLTO/X86/guid_collision.ll

  Log Message:
  -----------
  [LLD][ThinLTO] Handle GUID collision in import global processing

Summary:
If there are a GUID collision between two globals checking the
summarylist from the import index to make assumption can be dangerous.

Do not assume that a GlobalValue that has a GlobalVarSummary
actually is a GlobalVariable as it can be another GlobalValue with
the same GUID that the summary is connected to.

Patch by Joel Klinghed (the_jk at opera.com)

Reviewers: evgeny777, tejohnson

Reviewed By: tejohnson

Subscribers: tejohnson, dblaikie, MaskRay, mehdi_amini, inglorion, hiraditya, steven_wu, dexonsmith, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D67322