[all-commits] [llvm/llvm-project] 59a51d: [CodeGen][SelectionDAG] Fix tiny bug in ExpandIntR...

[Roman Lebedev via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 59a51d84b3a4f96bcc9669ee9c2b2041175a2ccd
      https://github.com/llvm/llvm-project/commit/59a51d84b3a4f96bcc9669ee9c2b2041175a2ccd
  Author: Itay Bookstein <ibookstein at gmail.com>
  Date:   2019-10-25 (Fri, 25 Oct 2019)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp

  Log Message:
  -----------
  [CodeGen][SelectionDAG] Fix tiny bug in ExpandIntRes_UADDSUBO

Summary:
Ternary expression checks for ISD::ADD instead of ISD::UADDO inside DAGTypeLegalizer::ExpandIntRes_UADDSUBO.
This means the ternary expression will evaluate to ISD::SUBCARRY for both ISD::UADDO and ISD::USUBO nodes.
Targets are likely to implement both, so impact will be very limited in practice.

Reviewers: bogner, lebedev.ri

Reviewed By: lebedev.ri

Subscribers: lebedev.ri, hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D68123


  Commit: b2c184458e990c8faeffd5047e7086e4f7ff07a6
      https://github.com/llvm/llvm-project/commit/b2c184458e990c8faeffd5047e7086e4f7ff07a6
  Author: Roman Lebedev <lebedev.ri at gmail.com>
  Date:   2019-10-25 (Fri, 25 Oct 2019)

  Changed paths:
    M llvm/include/llvm/ADT/APInt.h
    M llvm/lib/Support/APInt.cpp
    M llvm/unittests/ADT/APIntTest.cpp

  Log Message:
  -----------
  [APInt] Add saturating multiply ops

Summary:
There are `*_ov()` functions already, so at least for consistency it may be good to also have saturating variants.
These may or may not be needed for `ConstantRange`'s `mulWithNoWrap()`

Reviewers: spatel, nikic

Reviewed By: nikic

Subscribers: hiraditya, dexonsmith, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D69397


  Commit: 1cc8e1e1d7d78fc3f2185c5ba207cd21f227fa1c
      https://github.com/llvm/llvm-project/commit/1cc8e1e1d7d78fc3f2185c5ba207cd21f227fa1c
  Author: Roman Lebedev <lebedev.ri at gmail.com>
  Date:   2019-10-25 (Fri, 25 Oct 2019)

  Changed paths:
    M llvm/include/llvm/ADT/APInt.h
    M llvm/lib/Support/APInt.cpp
    M llvm/unittests/ADT/APIntTest.cpp

  Log Message:
  -----------
  [APInt] Add saturating left-shift ops

Summary:
There are `*_ov()` functions already, so at least for consistency it may be good to also have saturating variants.
These may or may not be needed for `ConstantRange`'s `shlWithNoWrap()`

Reviewers: spatel, nikic

Reviewed By: nikic

Subscribers: hiraditya, dexonsmith, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D69398


Compare: https://github.com/llvm/llvm-project/compare/6df7ef0d8baa...1cc8e1e1d7d7