[all-commits] [llvm/llvm-project] d52b36: [CMake] Remove unused variable LLDB_TEST_CXX_COMPILER

[Jonas Devlieghere via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: d52b36e354e94f518985833231375365a7cc334b
      https://github.com/llvm/llvm-project/commit/d52b36e354e94f518985833231375365a7cc334b
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2019-10-24 (Thu, 24 Oct 2019)

  Changed paths:
    M lldb/CMakeLists.txt
    M lldb/docs/resources/build.rst
    M lldb/docs/resources/test.rst
    M lldb/test/API/CMakeLists.txt

  Log Message:
  -----------
  [CMake] Remove unused variable LLDB_TEST_CXX_COMPILER

CMake allows you to set a custom CXX compiler for the API test suite.
However, this variable is never used, because dotest uses the same
compiler to build C and CXX sources.

I'm not sure if this variable was added with the intention of supporting
a different compiler or if this is just a remnant of old functionality.
Given that this hasn't been working for a while, I assume it's safe to
remove.

Differential revision: https://reviews.llvm.org/D69401


  Commit: 220cce1e7274e1d4b015965fad82ccd79d03b305
      https://github.com/llvm/llvm-project/commit/220cce1e7274e1d4b015965fad82ccd79d03b305
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2019-10-24 (Thu, 24 Oct 2019)

  Changed paths:
    M lldb/CMakeLists.txt
    M lldb/test/API/CMakeLists.txt

  Log Message:
  -----------
  [CMake] Don't set LLDB_TEST_* in the top-level CMakeLists

All these variables only affect the API tests. Therefore they belong in
test/API/CMakeLists.txt rather than the top-level CMakeLists.txt.


  Commit: fd025c094befe0ba23b044d0e7bc7876d2b40a0f
      https://github.com/llvm/llvm-project/commit/fd025c094befe0ba23b044d0e7bc7876d2b40a0f
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2019-10-24 (Thu, 24 Oct 2019)

  Changed paths:
    M lldb/CMakeLists.txt
    M lldb/cmake/modules/AddLLDB.cmake
    M lldb/test/CMakeLists.txt

  Log Message:
  -----------
  [CMake] Move test dependency tracking into test/CMakeLists.txt

As the name suggests, the LLDB test dependencies only matter to the
different test suites. Therefore they belong in test/CMakeLists.txt
rather than the top-level CMakeLists.txt.


  Commit: 33fca97880d3bd6ab4888b6eeb72bddff536e37a
      https://github.com/llvm/llvm-project/commit/33fca97880d3bd6ab4888b6eeb72bddff536e37a
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2019-10-24 (Thu, 24 Oct 2019)

  Changed paths:
    M lldb/CMakeLists.txt
    M lldb/test/CMakeLists.txt

  Log Message:
  -----------
  [CMake] Move LLDB_TEST_BUILD_DIRECTORY into test/CMakeLists.txt

The LLDB_TEST_BUILD_DIRECTORY variable only matters to the different
test suites. Therefore they belong in test/CMakeLists.txt rather than
the top-level CMakeLists.txt.


Compare: https://github.com/llvm/llvm-project/compare/a1817996fa86...33fca97880d3