[all-commits] [llvm/llvm-project] ec6660: [clang-format] Remove the dependency on frontend

MyDeveloperDay via All-commits all-commits at lists.llvm.org
Thu Oct 24 11:17:23 PDT 2019


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: ec66603ac7ea655be5c2c5f508c5bf0d5eaeb65b
      https://github.com/llvm/llvm-project/commit/ec66603ac7ea655be5c2c5f508c5bf0d5eaeb65b
  Author: paulhoad <mydeveloperday at gmail.com>
  Date:   2019-10-24 (Thu, 24 Oct 2019)

  Changed paths:
    M clang/tools/clang-format/CMakeLists.txt
    M clang/tools/clang-format/ClangFormat.cpp

  Log Message:
  -----------
  [clang-format] Remove the dependency on frontend

Summary:
Address review comments from {D68554} by trying to drop the dependency again on Frontend whilst keeping the same format diagnostic messages

Not completely happy with having to do a split in order to get the StringRef for the Line the error occurred on, but could see a way to use SourceManager and SourceLocation to give me a single line?

But this removes the dependency on frontend which should keep the binary size down.

Reviewers: thakis, klimek, mitchell-stellar

Reviewed By: klimek

Subscribers: mgorny, cfe-commits

Tags: #clang, #clang-format

Differential Revision: https://reviews.llvm.org/D68969




More information about the All-commits mailing list