[all-commits] [llvm/llvm-project] 684ebc: Revert 4334892e7b "[DAGCombine][ARM] x ==/!= c ->...

[Hans via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 684ebc605e0b7f8782e634e1bb3621a9b0ec674f
      https://github.com/llvm/llvm-project/commit/684ebc605e0b7f8782e634e1bb3621a9b0ec674f
  Author: Hans Wennborg <hans at chromium.org>
  Date:   2019-10-23 (Wed, 23 Oct 2019)

  Changed paths:
    M llvm/include/llvm/CodeGen/TargetLowering.h
    M llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp
    M llvm/test/CodeGen/ARM/addsubcarry-promotion.ll
    R llvm/test/CodeGen/X86/pr43769.ll

  Log Message:
  -----------
  Revert 4334892e7b "[DAGCombine][ARM] x ==/!= c  ->  (x - c) ==/!= 0  iff '-c' can be folded into the x node."

This broke various Windows builds, see comments on the Phabricator
review.

This also reverts the follow-up 20bf0cf.

> Summary:
> This fold, helps recover from the rest of the D62266 ARM regressions.
> https://rise4fun.com/Alive/TvpC
>
> Note that while the fold is quite flexible, i've restricted it
> to the single interesting pattern at the moment.
>
> Reviewers: efriedma, craig.topper, spatel, RKSimon, deadalnix
>
> Reviewed By: deadalnix
>
> Subscribers: javed.absar, kristof.beyls, llvm-commits
>
> Tags: #llvm
>
> Differential Revision: https://reviews.llvm.org/D62450