[all-commits] [llvm/llvm-project] 78d632: [LLVMDebugInfoPDB] - Use cantFail() instead of ass...

[llvm-git-migration via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 78d632d1055467dd2880dc9ff6dfdc554505eda7
      https://github.com/llvm/llvm-project/commit/78d632d1055467dd2880dc9ff6dfdc554505eda7
  Author: George Rimar <grimar at accesssoftek.com>
  Date:   2019-10-22 (Tue, 22 Oct 2019)

  Changed paths:
    M llvm/lib/DebugInfo/PDB/Native/NativeEnumInjectedSources.cpp

  Log Message:
  -----------
  [LLVMDebugInfoPDB] - Use cantFail() instead of assert().

Currently injected-sources-native.test fails with "Expected<T>
value was in success state.
(Note: Expected<T> values in success mode must still be checked
prior to being destroyed)"
when llvm is compiled with LLVM_ENABLE_ABI_BREAKING_CHECKS in Release.

The problem is that getStringForID returns Expected<StringRef>
and Expected value must always be checked, even if it is in success state.
Checking with assert only helps in Debug and is wrong.

Differential revision: https://reviews.llvm.org/D69251

llvm-svn: 375492