[all-commits] [llvm/llvm-project] 238653: [LLDB] bugfix: command script add -f doesn't work ...

[llvm-git-migration via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 2386537c2469a97501a305c6b3138231b907a67f
      https://github.com/llvm/llvm-project/commit/2386537c2469a97501a305c6b3138231b907a67f
  Author: Lawrence D'Anna <lawrence_danna at apple.com>
  Date:   2019-10-19 (Sat, 19 Oct 2019)

  Changed paths:
    M lldb/packages/Python/lldbsuite/test/commands/command/script/TestCommandScript.py
    A lldb/packages/Python/lldbsuite/test/commands/command/script/callables.py
    M lldb/packages/Python/lldbsuite/test/commands/command/script/py_import
    M lldb/scripts/Python/python-wrapper.swig
    M lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp
    M lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h
    M lldb/unittests/ScriptInterpreter/Python/PythonDataObjectsTests.cpp

  Log Message:
  -----------
  [LLDB] bugfix: command script add -f doesn't work for some callables

Summary:
When users define a debugger command from python, they provide a callable
object.   Because the signature of the function has been extended, LLDB
needs to inspect the number of parameters the callable can take.

The rule it was using to decide was weird, apparently not tested, and
giving wrong results for some kinds of python callables.

This patch replaces the weird rule with a simple one: if the callable can
take 5 arguments, it gets the 5 argument version of the signature.
Otherwise it gets the old 4 argument version.

It also adds tests with a bunch of different kinds of python callables
with both 4 and 5 arguments.

Reviewers: JDevlieghere, clayborg, labath, jingham

Reviewed By: labath

Subscribers: lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D69014

llvm-svn: 375333