[all-commits] [llvm/llvm-project] 32ce14: Disable exit-on-SIGPIPE in lldb
Vedant Kumar via All-commits
all-commits at lists.llvm.org
Fri Oct 18 14:04:24 PDT 2019
Branch: refs/heads/master
Home: https://github.com/llvm/llvm-project
Commit: 32ce14e55e5a99dd99c3b4fd4bd0ccaaf2948c30
https://github.com/llvm/llvm-project/commit/32ce14e55e5a99dd99c3b4fd4bd0ccaaf2948c30
Author: Vedant Kumar <vsk at apple.com>
Date: 2019-10-18 (Fri, 18 Oct 2019)
Changed paths:
M lldb/tools/driver/Driver.cpp
M llvm/include/llvm/Support/Signals.h
M llvm/lib/Support/Unix/Signals.inc
M llvm/lib/Support/Windows/Signals.inc
M llvm/unittests/Support/CMakeLists.txt
A llvm/unittests/Support/SignalsTest.cpp
Log Message:
-----------
Disable exit-on-SIGPIPE in lldb
Occasionally, during test teardown, LLDB writes to a closed pipe.
Sometimes the communication is inherently unreliable, so LLDB tries to
avoid being killed due to SIGPIPE (it calls `signal(SIGPIPE, SIG_IGN)`).
However, LLVM's default SIGPIPE behavior overrides LLDB's, causing it to
exit with IO_ERR.
Opt LLDB out of the default SIGPIPE behavior. I expect that this will
resolve some LLDB test suite flakiness (tests randomly failing with
IO_ERR) that we've seen since r344372.
rdar://55750240
Differential Revision: https://reviews.llvm.org/D69148
llvm-svn: 375288
More information about the All-commits
mailing list