[all-commits] [llvm/llvm-project] 788acc: [libunwind][Android] Fix findUnwindSections for AR...

Ryan Prichard via All-commits all-commits at lists.llvm.org
Fri Oct 18 12:58:07 PDT 2019

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 788acc6ff8ee3b2fc16a3f68179b0b445f6f4381
  Author: Ryan Prichard <rprichard at google.com>
  Date:   2019-10-18 (Fri, 18 Oct 2019)

  Changed paths:
    M libunwind/src/AddressSpace.hpp
    M libunwind/src/UnwindCursor.hpp

  Log Message:
  [libunwind][Android] Fix findUnwindSections for ARM EHABI Bionic

Fix the arm_section_length count. The meaning of the arm_section_length
field changed from num-of-elements to num-of-bytes when the
dl_unwind_find_exidx special case was removed (D30306 and D30681). The
special case was restored in D39468, but that patch didn't account for the
change in arm_section_length's meaning.

That patch worked when it was applied to the NDK's fork of libunwind,
because it never removed the special case in the first place, and the
special case is probably disabled in the Android platform's copy of
libunwind, because __ANDROID_API__ is greater than 21.

Turn the dl_unwind_find_exidx special case on unconditionally for Bionic.
Bionic's dl_unwind_find_exidx is much faster than using dl_iterate_phdr.
(e.g. Bionic stores exidx info on an internal soinfo object.)

Reviewers: thomasanderson, srhines, danalbert, ed, keith.walker.arm, mclow.lists, compnerd

Reviewed By: srhines, danalbert

Subscribers: srhines, kristof.beyls, christof, libcxx-commits

Tags: #libc

Differential Revision: https://reviews.llvm.org/D68972

llvm-svn: 375275

More information about the All-commits mailing list