[all-commits] [llvm/llvm-project] 6caada: [clang-offload-wrapper][NFC] Use captured name of ...

Jordan Rupprecht via All-commits all-commits at lists.llvm.org
Thu Oct 17 14:54:35 PDT 2019

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 6caada4eb4654783a45f6ae7bb1cd0eebcf4b0bb
  Author: Sergey Dmitriev <serguei.n.dmitriev at intel.com>
  Date:   2019-10-17 (Thu, 17 Oct 2019)

  Changed paths:
    M clang/test/Driver/clang-offload-wrapper.c

  Log Message:
  [clang-offload-wrapper][NFC] Use captured name of the entry type in LIT test

Differential Revision: https://reviews.llvm.org/D69140

llvm-svn: 375177

  Commit: 98a2ae7dadf897305e1cc2d9a5d63edf925c07f7
  Author: Jordan Rupprecht <rupprecht at google.com>
  Date:   2019-10-17 (Thu, 17 Oct 2019)

  Changed paths:
    M llvm/test/tools/llvm-objdump/xcoff-section-headers.test
    M llvm/tools/llvm-objdump/llvm-objdump.cpp
    M llvm/tools/llvm-objdump/llvm-objdump.h

  Log Message:
  Reland [llvm-objdump] Use a counter for llvm-objdump -h instead of the section index.

This relands r374931 (reverted in r375088). It fixes 32-bit builds by using the right format string specifier for uint64_t (PRIu64) instead of `%d`.

Original description:

When listing the index in `llvm-objdump -h`, use a zero-based counter instead of the actual section index (e.g. shdr->sh_index for ELF).

While this is effectively a noop for now (except one unit test for XCOFF), the index values will change in a future patch that filters certain sections out (e.g. symbol tables). See D68669 for more context. Note: the test case in `test/tools/llvm-objdump/X86/section-index.s` already covers the case of incrementing the section index counter when sections are skipped.

Reviewers: grimar, jhenderson, espindola

Reviewed By: grimar

Subscribers: emaste, sbc100, arichardson, aheejin, arphaman, seiya, llvm-commits, MaskRay

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D68848

llvm-svn: 375178

Compare: https://github.com/llvm/llvm-project/compare/ecb310b3a7cf...98a2ae7dadf8

More information about the All-commits mailing list