[all-commits] [llvm/llvm-project] fc69ad: [codeview] Workaround for PR43479, don't re-emit i...

Reid Kleckner via All-commits all-commits at lists.llvm.org
Thu Oct 17 10:27:21 PDT 2019

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: fc69ad09882ccfbedc2d06afc971d59eb6a24ee0
  Author: Reid Kleckner <rnk at google.com>
  Date:   2019-10-17 (Thu, 17 Oct 2019)

  Changed paths:
    M llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
    A llvm/test/CodeGen/X86/taildup-heapallocsite.ll

  Log Message:
  [codeview] Workaround for PR43479, don't re-emit instr labels

In the long run we should come up with another mechanism for marking
call instructions as heap allocation sites, and remove this workaround.
For now, we've had two bug reports about this, so let's apply this
workaround. SLH (the other client of instruction labels) probably has
the same bug, but the solution there is more likely to be to mark the
call instruction as not duplicatable, which doesn't work for debug info.

Reviewers: akhuang

Subscribers: aprantl, hiraditya, aganea, chandlerc, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D69068

llvm-svn: 375137

More information about the All-commits mailing list