[all-commits] [llvm/llvm-project] 312c4a: Revert r374931 "[llvm-objdump] Use a counter for l...

Hans via All-commits all-commits at lists.llvm.org
Thu Oct 17 01:51:21 PDT 2019

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 312c4a6e248988a6aca72b47667c25636a319602
  Author: Hans Wennborg <hans at hanshq.net>
  Date:   2019-10-17 (Thu, 17 Oct 2019)

  Changed paths:
    M llvm/test/tools/llvm-objdump/xcoff-section-headers.test
    M llvm/tools/llvm-objdump/llvm-objdump.cpp
    M llvm/tools/llvm-objdump/llvm-objdump.h

  Log Message:
  Revert r374931 "[llvm-objdump] Use a counter for llvm-objdump -h instead of the section index."

This broke llvm-objdump in 32-bit builds, see e.g.

> Summary:
> When listing the index in `llvm-objdump -h`, use a zero-based counter instead of the actual section index (e.g. shdr->sh_index for ELF).
> While this is effectively a noop for now (except one unit test for XCOFF), the index values will change in a future patch that filters certain sections out (e.g. symbol tables). See D68669 for more context. Note: the test case in `test/tools/llvm-objdump/X86/section-index.s` already covers the case of incrementing the section index counter when sections are skipped.
> Reviewers: grimar, jhenderson, espindola
> Reviewed By: grimar
> Subscribers: emaste, sbc100, arichardson, aheejin, arphaman, seiya, llvm-commits, MaskRay
> Tags: #llvm
> Differential Revision: https://reviews.llvm.org/D68848

llvm-svn: 375088

More information about the All-commits mailing list