Hi Will,<br><br><div class="gmail_quote">On Thu, Nov 3, 2011 at 3:48 PM, Will Dietz <span dir="ltr"><<a href="mailto:wdietz2@illinois.edu">wdietz2@illinois.edu</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
Inlined below.<br>
<br>
This change seems benign, but I'm not sure if it's masking some other<br>
bug I should be concerned about.<br>
<br>
Patch primarily a discussion point, although could be committed too<br>
(since it's rather minor).<br>
<br>
FWIW, with this patch (and the previous ones), we can build a<br>
OpenJDK-based VMKit that can run many simple codes, and on larger<br>
codes seems to only fail when encountering some of the many NYI()'d<br>
(or intentionally unimplemented) pieces. Which is kinda neat! :)<br></blockquote><div><br></div><div>Definitely! That's a giant step! Any plans on sending the instructions on which OpenJDK to use? How to configure, etc? :)</div>
<div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<br>
In the future I hope to focus on getting it to run various codes<br>
better (dacapo being my big goal, but not the full story), and try to<br>
generally improve misc behavior compatibility/compliance-wise :).<br></blockquote><div><br></div><div>Big encouragements for getting dacapo to run, especially all benchmarks of the latest version (which do not run on GNU Classpath).</div>
<div><br></div><div>There is also SpecJVM2008 I think, that anyone can download. It'd be neat to have that running too :)</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<br>
Thanks!<br>
<br>
~Will<br>
<br>
>From 0462e91eb86e28c00707c40d624853eb51679904 Mon Sep 17 00:00:00 2001<br>
From: Will Dietz <<a href="mailto:w@wdtz.org">w@wdtz.org</a>><br>
Date: Wed, 2 Nov 2011 23:02:45 -0500<br>
Subject: [PATCH 15/17] Remove System.err.println from mmtk stuff to fix dep<br>
on bootstrap<br>
<br>
Not entirely sure, but with these present we get linker errors with<br>
libFinalMMtk.a on misc pieces that are pulled in from System.err,<br>
namely things like sun.nio.cs.StreamEncoder.<br></blockquote><div><br></div><div>This may just be a limitation of the AOT compiler, which pulls out more than it actually needs. I'd be interested to see the error messages if you still have them.</div>
<div> </div><div>Patch is fine to commit because it just touches mmtk/src/org/j3 files. Note that if it were to touch other mmtk/src/org files, it wouldn't be as fine because it's code that is imported from mmtk. And this code we should try to not deviate from it, to avoid merge conflicts.</div>
<div><br></div><div>Again, that's a great step forward! Nice work. I'm looking forward to see all the dacapo benchmarks run on vmkit :)</div><div><br></div><div>Nicolas</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<br>
On one hand this seems like an undiagnosed failure of the precompilation,<br>
however we're not trying to build System.err things while<br>
compiling mmtk, and this change is relatively minor.<br>
---<br>
mmtk/java/src/org/j3/mmtk/BuildTimeConfig.java | 4 ++--<br>
1 files changed, 2 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/mmtk/java/src/org/j3/mmtk/BuildTimeConfig.java<br>
b/mmtk/java/src/org/j3/mmtk/BuildTimeConfig.java<br>
index 8dc8f82..9f90b8e 100644<br>
--- a/mmtk/java/src/org/j3/mmtk/BuildTimeConfig.java<br>
+++ b/mmtk/java/src/org/j3/mmtk/BuildTimeConfig.java<br>
@@ -53,7 +53,7 @@ public final class BuildTimeConfig extends<br>
org.mmtk.vm.BuildTimeConfig {<br>
if (default_property_file == null) {<br>
propFileName = System.getProperty(property_file_property);<br>
if (propFileName == null) {<br>
- System.err.println(property_file_property+" must specify a<br>
properties file");<br>
+ //System.err.println(property_file_property+" must specify a<br>
properties file");<br>
VM.sysExit(1);<br>
}<br>
} else {<br>
@@ -67,7 +67,7 @@ public final class BuildTimeConfig extends<br>
org.mmtk.vm.BuildTimeConfig {<br>
propFileStream.close();<br>
} catch (FileNotFoundException e) {<br>
if (!propFileName.equals(default_property_file)) {<br>
- System.err.println(propFileName+" not found.");<br>
+ //System.err.println(propFileName+" not found.");<br>
VM.sysExit(1);<br>
}<br>
} catch (IOException e) {<br>
<span class="HOEnZb"><font color="#888888">--<br>
1.7.5.1<br>
_______________________________________________<br>
vmkit-commits mailing list<br>
<a href="mailto:vmkit-commits@cs.uiuc.edu">vmkit-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/vmkit-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/vmkit-commits</a><br>
</font></span></blockquote></div><br>