[vmkit-commits] [PATCH] Hook JnjvmClassLoader to make use of appropriate Classpath

Will Dietz wdietz2 at illinois.edu
Wed Oct 26 13:24:12 PDT 2011


On Wed, Oct 26, 2011 at 3:09 PM, Nicolas Geoffray
<nicolas.geoffray at gmail.com> wrote:
> Looks good, but
>> +  // Load OpenJDK's libjava.so
>> +  assert(loader->loadLib(OpenJDKLibJava));
>
> The assert can be removed by the compiler. Is that the intended behavior of
> your change? Maybe you should do:
> void* res = loader->loadLib(OpenJDKLibJava);
> assert(res);
> ?

Yes, that's what I meant. Thanks! :)

~Will




More information about the vmkit-commits mailing list