[vmkit-commits] New exception model

[Will Dietz]

Looks great, and thank you very much for the heads-up!

It does change things (especially in the JVM_* implementations
to-come), but I'm reworking those a bit anyway so changing to reflect
this shouldn't be a problem.

Looking forward to seeing it hit mainline (and any corresponding LLVM
patches :)).

Thanks,

~Will

On Tue, Oct 25, 2011 at 4:57 PM, Nicolas Geoffray
<nicolas.geoffray at gmail.com> wrote:
> Local changes got introduced into the previous patch. Uploading the correct
> one.
>
> On Tue, Oct 25, 2011 at 11:53 PM, Nicolas Geoffray
> <nicolas.geoffray at gmail.com> wrote:
>>
>> Will,
>> I will be submitting the attached patch to VMKit soon. It's a rewrite of
>> how we handle exceptions. Basically:
>> Before: use setjmp/longjmp for C++, do exception checks after each call in
>> Java
>> After: use setjmp/longjmp for C++ and Java
>> My plan is to uniform both worlds when it comes to exceptions and
>> eventually change some code in LLVM for maximizing performance.
>> At the code level, the only thing that you need to know (I think) is that
>> you should not change the current's thread pending exception directly (in
>> C++ code), but instead should call the throwException method.
>> This may break some of your code in OpenJDK, so let me know if you have
>> questions. Otherwise, I'll submit the patch.
>> Cheers,
>> Nicolas
>