[vmkit-commits] [PATCH] NYI-out things not yet in the OpenJDK port

[Will Dietz]

On Tue, Oct 25, 2011 at 12:30 PM, Nicolas Geoffray
<nicolas.geoffray at gmail.com> wrote:
> Actually, I'm not really fond of macros spread over the code. What I would
> do is create two files, one for the OpenJDK implementation and one for
> Classpath. They would contain the implementation specific methods. Ideally:
> lib/J3/ClassLib/Classpath/Jni.cpp
> lib/J3/ClassLib/OpenJDK/Jni.cpp
> Or else:
> lib/J3/VMCore/JniOpenJDK.inc
> lib/J3/VMCore/JniClasspath.inc
> And at the end of Jni.cpp do:
> #ifdef USE_OPENJDK
> #include "JniOpenJDK.inc"
> #else
> #include "JniClasspath.inc"
> #endif
> Would that make sense? You can take the approach that suits you best.
> Nicolas

Sure thing, that definitely makes sense and where I wanted things to
go eventually anyway.  Thanks! :)

~Will