[vmkit-commits] [PATCH] Add 'USE_OPENJDK' flag that can be used for conditional compilation

Nicolas Geoffray nicolas.geoffray at gmail.com
Tue Oct 25 10:25:04 PDT 2011


Looks good!

On Tue, Oct 25, 2011 at 12:37 AM, Will Dietz <wdietz2 at illinois.edu> wrote:

> Inlined below.
>
> Using conditional compilation for now-- once the openjdk "works" to
> some capacity, reviewing how to restructure the code might be worth
> revisiting.
>
> Doing so before then seems a tad premature, and this keeps changes
> smaller in the meanwhile.
>
> ~Will
>
> diff --git a/Makefile.common.in b/Makefile.common.in
> index 0976a30..f326a55 100755
> --- a/Makefile.common.in
> +++ b/Makefile.common.in
> @@ -39,6 +39,12 @@ CXX.Flags += @GC_FLAGS@ -fno-exceptions
> -Wno-variadic-macros -fno-omit-frame-poi
>  CLASSPATH_FLAGS =
>  GLIBJ = @classpathglibj@
>
> +# Using conditional compilation for now, until a proper
> interface/architecture
> +# is figured out and implemented.
> +ifeq (@classpathimpl@,openjdk)
> +CXX.Flags += -DUSE_OPENJDK
> +endif
> +
>  LIBS += -lz
>
>  include $(PROJ_SRC_ROOT)/Makefile.rules
> --
> 1.7.5.1
> _______________________________________________
> vmkit-commits mailing list
> vmkit-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/vmkit-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/vmkit-commits/attachments/20111025/4d62c898/attachment.html>


More information about the vmkit-commits mailing list