[vmkit-commits] [PATCH] Various patches

[Nicolas Geoffray]

Hi Will,

That's great! Here's my first comments. I'll try to review your other
patches ASAP. Do you have commit access to the llvm repo?

patches 1, 2, 3: look good!

patch 4: looking at the code, I realize that NATIVE_JNI is completely bogus
today, so you can safely remove the use of the macro and the arguments it
surrounds. Also, even though it's just casts, you should not use jobject and
jclass in these methods. Just use JavaObject. Also, please remove the //
printf.

patch 5: looks good!

On Tue, Oct 18, 2011 at 12:41 AM, Will Dietz <willdtz at gmail.com> wrote:

> Hi,
>
> Attached are various patches that I've refactored out from the OpenJDK
> port, as they aren't necessarily part of switching runtimes and help
> the Classpath implementation too.
>
> Hopefully OpenJDK patches will be coming in the semi-near future...
>
> Please let me know if you have any questions or comments, I'm rather
> happy to discuss :).
>
> Thanks, and have a good one!
>
> ~Will
>
> _______________________________________________
> vmkit-commits mailing list
> vmkit-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/vmkit-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/vmkit-commits/attachments/20111018/0361875c/attachment.html>