[vmkit-commits] [PATCH] Implement JVM_SetThreadPriority

[Nicolas Geoffray]

Looks good with one comment.

On Tue, Nov 1, 2011 at 5:41 AM, Will Dietz <wdietz2 at illinois.edu> wrote:

> Inlined below.
>
> ~Will
>
> >From ca5573058b469fe5868e7f807b1567252db848e2 Mon Sep 17 00:00:00 2001
> From: Will Dietz <w at wdtz.org>
> Date: Mon, 31 Oct 2011 16:12:34 -0500
> Subject: [PATCH 2/8] Implement JVM_SetThreadPriority
>
> ---
>  lib/J3/ClassLib/OpenJDK/OpenJDK.inc |   14 +++++++++++++-
>  1 files changed, 13 insertions(+), 1 deletions(-)
>
> diff --git a/lib/J3/ClassLib/OpenJDK/OpenJDK.inc
> b/lib/J3/ClassLib/OpenJDK/OpenJDK.inc
> index d9c1a78..0360894 100644
> --- a/lib/J3/ClassLib/OpenJDK/OpenJDK.inc
> +++ b/lib/J3/ClassLib/OpenJDK/OpenJDK.inc
> @@ -479,7 +479,19 @@ JVM_ResumeThread(JNIEnv *env, jobject thread) {
>
>  JNIEXPORT void JNICALL
>  JVM_SetThreadPriority(JNIEnv *env, jobject thread, jint prio) {
> -  NYI();
> +  JavaObject * T;
> +  llvm_gcroot(thread, 0);
>

thread is not a GC object, it's a pointer to it. So you should never
llvm_gcroot it.


> +  llvm_gcroot(T, 0);
> +
> +  BEGIN_JNI_EXCEPTION
> +
> +  Jnjvm * vm = th->getJVM();
> +  T = *(JavaObject**)thread;
> +
> +  vm->upcalls->priority->setInstanceInt32Field(T, prio);
> +
> +  RETURN_VOID_FROM_JNI
> +  END_JNI_EXCEPTION
>  }
>
>  JNIEXPORT void JNICALL
> --
> 1.7.5.1
> _______________________________________________
> vmkit-commits mailing list
> vmkit-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/vmkit-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/vmkit-commits/attachments/20111101/1f2419b8/attachment.html>