<div dir="ltr">I've got a patch up now that I think will fix this error: <a href="https://reviews.llvm.org/D24949">https://reviews.llvm.org/D24949</a>.</div><br><div class="gmail_quote"><div dir="ltr">On Mon, Sep 26, 2016 at 4:53 PM Jason Henline <<a href="mailto:jhen@google.com">jhen@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="gmail_msg">I will take a look to see if I can get this fixed.</div><br class="gmail_msg"><div class="gmail_quote gmail_msg"><div dir="ltr" class="gmail_msg">On Mon, Sep 26, 2016 at 4:41 PM Justin Lebar <<a href="mailto:jlebar@google.com" class="gmail_msg" target="_blank">jlebar@google.com</a>> wrote:<br class="gmail_msg"></div><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Not to throw this over the fence, but Jason, are you in a better<br class="gmail_msg">
position to look into this?<br class="gmail_msg">
<br class="gmail_msg">
On Mon, Sep 26, 2016 at 4:37 PM, Hal Finkel <<a href="mailto:hfinkel@anl.gov" class="gmail_msg" target="_blank">hfinkel@anl.gov</a>> wrote:<br class="gmail_msg">
> Hi Justin,<br class="gmail_msg">
><br class="gmail_msg">
> I'm seeing a problem configuring a build that has both parallel-libs and lld in-tree...<br class="gmail_msg">
><br class="gmail_msg">
> CMake Error at cmake/modules/AddLLVM.cmake:645 (add_executable):<br class="gmail_msg">
> add_executable cannot create target "CoreTests" because another target with<br class="gmail_msg">
> the same name already exists. The existing target is an executable created<br class="gmail_msg">
> in source directory<br class="gmail_msg">
> "path/to/llvm/projects/parallel-libs/streamexecutor/unittests/CoreTests".<br class="gmail_msg">
> See documentation for policy CMP0002 for more details.<br class="gmail_msg">
> Call Stack (most recent call first):<br class="gmail_msg">
> cmake/modules/AddLLVM.cmake:977 (add_llvm_executable)<br class="gmail_msg">
> tools/lld/unittests/CMakeLists.txt:11 (add_unittest)<br class="gmail_msg">
> tools/lld/unittests/CoreTests/CMakeLists.txt:1 (add_lld_unittest)<br class="gmail_msg">
><br class="gmail_msg">
> -Hal<br class="gmail_msg">
><br class="gmail_msg">
> ----- Original Message -----<br class="gmail_msg">
>> From: "Justin Lebar via Parallel_libs-commits" <<a href="mailto:parallel_libs-commits@lists.llvm.org" class="gmail_msg" target="_blank">parallel_libs-commits@lists.llvm.org</a>><br class="gmail_msg">
>> To: "parallel libs-commits" <<a href="mailto:parallel_libs-commits@lists.llvm.org" class="gmail_msg" target="_blank">parallel_libs-commits@lists.llvm.org</a>><br class="gmail_msg">
>> Sent: Friday, September 9, 2016 4:01:03 PM<br class="gmail_msg">
>> Subject: [Parallel_libs-commits] [parallel-libs] r281091 - [StreamExecutor] Make SE work with an in-tree LLVM build.<br class="gmail_msg">
>><br class="gmail_msg">
>> Author: jlebar<br class="gmail_msg">
>> Date: Fri Sep 9 16:01:02 2016<br class="gmail_msg">
>> New Revision: 281091<br class="gmail_msg">
>><br class="gmail_msg">
>> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=281091&view=rev" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project?rev=281091&view=rev</a><br class="gmail_msg">
>> Log:<br class="gmail_msg">
>> [StreamExecutor] Make SE work with an in-tree LLVM build.<br class="gmail_msg">
>><br class="gmail_msg">
>> Summary:<br class="gmail_msg">
>> With these changes, we can put parallel-libs within llvm/projects and<br class="gmail_msg">
>> build as normal.<br class="gmail_msg">
>><br class="gmail_msg">
>> This is kind of the minimal change I could figure out how to make<br class="gmail_msg">
>> while<br class="gmail_msg">
>> still making us compatible with llvm's build system. Some things I'm<br class="gmail_msg">
>> not thrilled about include:<br class="gmail_msg">
>><br class="gmail_msg">
>> * The creation of a CoreTests directory (the macros really seemed to<br class="gmail_msg">
>> want this)<br class="gmail_msg">
>><br class="gmail_msg">
>> * Pulling SimpleHostPlatformDevice.h into CoreTests. It seems to me<br class="gmail_msg">
>> this should live inside unittests/include, or maybe tests/include,<br class="gmail_msg">
>> but I didn't want to make that change in this patch.<br class="gmail_msg">
>><br class="gmail_msg">
>> One important piece of work that remains to be done is to make<br class="gmail_msg">
>><br class="gmail_msg">
>> $ ninja check-streamexecutor<br class="gmail_msg">
>><br class="gmail_msg">
>> run all the tests. Right now the only way I've figured out to run<br class="gmail_msg">
>> the<br class="gmail_msg">
>> tests is<br class="gmail_msg">
>><br class="gmail_msg">
>> $ ninja<br class="gmail_msg">
>> projects/parallel-libs/streamexecutor/unittests/StreamExecutorUnitTests<br class="gmail_msg">
>> $<br class="gmail_msg">
>> projects/parallel-libs/streamexecutor/unittests/CoreTests/CoreTests<br class="gmail_msg">
>><br class="gmail_msg">
>> Reviewers: jhen<br class="gmail_msg">
>><br class="gmail_msg">
>> Subscribers: beanz, parallel_libs-commits, jprice<br class="gmail_msg">
>><br class="gmail_msg">
>> Differential Revision: <a href="https://reviews.llvm.org/D24368" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D24368</a><br class="gmail_msg">
>><br class="gmail_msg">
>> Added:<br class="gmail_msg">
>> parallel-libs/trunk/CMakeLists.txt<br class="gmail_msg">
>> parallel-libs/trunk/streamexecutor/lib/Utils/CMakeLists.txt<br class="gmail_msg">
>> parallel-libs/trunk/streamexecutor/unittests/<br class="gmail_msg">
>> parallel-libs/trunk/streamexecutor/unittests/CMakeLists.txt<br class="gmail_msg">
>> parallel-libs/trunk/streamexecutor/unittests/CoreTests/<br class="gmail_msg">
>> parallel-libs/trunk/streamexecutor/unittests/CoreTests/CMakeLists.txt<br class="gmail_msg">
>> parallel-libs/trunk/streamexecutor/unittests/CoreTests/DeviceTest.cpp<br class="gmail_msg">
>> - copied, changed from r280955,<br class="gmail_msg">
>> parallel-libs/trunk/streamexecutor/lib/unittests/DeviceTest.cpp<br class="gmail_msg">
>> parallel-libs/trunk/streamexecutor/unittests/CoreTests/KernelSpecTest.cpp<br class="gmail_msg">
>> - copied, changed from r280955,<br class="gmail_msg">
>> parallel-libs/trunk/streamexecutor/lib/unittests/KernelSpecTest.cpp<br class="gmail_msg">
>> parallel-libs/trunk/streamexecutor/unittests/CoreTests/PackedKernelArgumentArrayTest.cpp<br class="gmail_msg">
>> - copied, changed from r280955,<br class="gmail_msg">
>> parallel-libs/trunk/streamexecutor/lib/unittests/PackedKernelArgumentArrayTest.cpp<br class="gmail_msg">
>> parallel-libs/trunk/streamexecutor/unittests/CoreTests/SimpleHostPlatformDevice.h<br class="gmail_msg">
>> - copied, changed from r280955,<br class="gmail_msg">
>> parallel-libs/trunk/streamexecutor/lib/unittests/SimpleHostPlatformDevice.h<br class="gmail_msg">
>> parallel-libs/trunk/streamexecutor/unittests/CoreTests/StreamTest.cpp<br class="gmail_msg">
>> - copied, changed from r280955,<br class="gmail_msg">
>> parallel-libs/trunk/streamexecutor/lib/unittests/StreamTest.cpp<br class="gmail_msg">
>> Removed:<br class="gmail_msg">
>> parallel-libs/trunk/streamexecutor/lib/unittests/CMakeLists.txt<br class="gmail_msg">
>> parallel-libs/trunk/streamexecutor/lib/unittests/DeviceTest.cpp<br class="gmail_msg">
>> parallel-libs/trunk/streamexecutor/lib/unittests/KernelSpecTest.cpp<br class="gmail_msg">
>> parallel-libs/trunk/streamexecutor/lib/unittests/PackedKernelArgumentArrayTest.cpp<br class="gmail_msg">
>> parallel-libs/trunk/streamexecutor/lib/unittests/SimpleHostPlatformDevice.h<br class="gmail_msg">
>> parallel-libs/trunk/streamexecutor/lib/unittests/StreamTest.cpp<br class="gmail_msg">
>> Modified:<br class="gmail_msg">
>> parallel-libs/trunk/streamexecutor/CMakeLists.txt<br class="gmail_msg">
>> parallel-libs/trunk/streamexecutor/lib/CMakeLists.txt<br class="gmail_msg">
>><br class="gmail_msg">
>> Added: parallel-libs/trunk/CMakeLists.txt<br class="gmail_msg">
>> URL:<br class="gmail_msg">
>> <a href="http://llvm.org/viewvc/llvm-project/parallel-libs/trunk/CMakeLists.txt?rev=281091&view=auto" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/parallel-libs/trunk/CMakeLists.txt?rev=281091&view=auto</a><br class="gmail_msg">
> ...<br class="gmail_msg">
>><br class="gmail_msg">
>><br class="gmail_msg">
>> _______________________________________________<br class="gmail_msg">
>> Parallel_libs-commits mailing list<br class="gmail_msg">
>> <a href="mailto:Parallel_libs-commits@lists.llvm.org" class="gmail_msg" target="_blank">Parallel_libs-commits@lists.llvm.org</a><br class="gmail_msg">
>> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/parallel_libs-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/parallel_libs-commits</a><br class="gmail_msg">
>><br class="gmail_msg">
><br class="gmail_msg">
> --<br class="gmail_msg">
> Hal Finkel<br class="gmail_msg">
> Lead, Compiler Technology and Programming Languages<br class="gmail_msg">
> Leadership Computing Facility<br class="gmail_msg">
> Argonne National Laboratory<br class="gmail_msg">
</blockquote></div></blockquote></div>