[Parallel_libs-commits] [PATCH] D24580: [SE] Let users specify CUDA path

[Jason Henline via Parallel_libs-commits]

jhen added a comment.

In https://reviews.llvm.org/D24580#543280, @jprice wrote:

> Alas, this still doesn't work for OS X. It seems that `CUDA_DRIVER_LIBRARY` is set to the full path to the framework (e.g. `/Library/Frameworks/cuda.framework`) whereas the flag that needs to be passed is `-framework cuda`. CMake automagically sorts this out when passing the framework path to `target_link_libraries`, but I'm not sure there's a simple way of getting it to spit out the correct flag for `streamexecutor-config` in a platform independent manner.


What do you think of the idea of doing a check in Python to see if the library base name is `*.framework` and then emitting the flag `-lframework *` instead of the raw path, if so? It's hacky, but it seems like it might work pretty much all the time.

> This doesn't have to hold up this patch BTW, I just thought I'd mention it here since I noticed it.


I can't tell you how much I appreciate the work you are doing checking StreamExecutor on different platforms.


https://reviews.llvm.org/D24580