[Parallel_libs-commits] [PATCH] D24468: [SE] Add .clang-format

Justin Lebar via Parallel_libs-commits parallel_libs-commits at lists.llvm.org
Mon Sep 12 16:02:05 PDT 2016


jlebar added a comment.

WRT the noexcept check: This is actually relevant even if SE is compiled with exceptions disabled.

If you have a moveable and copyable class with a non-noexcept move constructor and you insert it into a vector, when the vector resizes itself, it will call the copy constructor, not the move constructor.  Even if you compile with -fno-exceptions.

It's nuts, I know.

Whether this is something we want to enforce in the SE code or not, I don't know.  Apparently it's something we enforce in LLVM only in aspiration.  :)


https://reviews.llvm.org/D24468





More information about the Parallel_libs-commits mailing list