[Parallel_libs-commits] [PATCH] D24368: [StreamExecutor] Make SE work with an in-tree LLVM build.

Justin Lebar via Parallel_libs-commits parallel_libs-commits at lists.llvm.org
Thu Sep 8 17:04:19 PDT 2016


jlebar created this revision.
jlebar added a reviewer: jhen.
jlebar added subscribers: jprice, parallel_libs-commits.
Herald added a subscriber: beanz.

With these changes, we can put parallel-libs within llvm/projects and
build as normal.

This is kind of the minimal change I could figure out how to make while
still making us compatible with llvm's build system.  Some things I'm
not thrilled about include:

 * The creation of a CoreTests directory (the macros really seemed to
   want this)

 * Pulling SimpleHostPlatformDevice.h into CoreTests.  It seems to me
   this should live inside unittests/include, or maybe tests/include,
   but I didn't want to make that change in this patch.

One important piece of work that remains to be done is to make

  $ ninja check-streamexecutor

run all the tests.  Right now the only way I've figured out to run the
tests is

  $ ninja projects/parallel-libs/streamexecutor/unittests/StreamExecutorUnitTests
  $ projects/parallel-libs/streamexecutor/unittests/CoreTests/CoreTests

https://reviews.llvm.org/D24368

Files:
  CMakeLists.txt
  streamexecutor/CMakeLists.txt
  streamexecutor/lib/CMakeLists.txt
  streamexecutor/lib/Utils/CMakeLists.txt
  streamexecutor/lib/unittests/CMakeLists.txt
  streamexecutor/lib/unittests/DeviceTest.cpp
  streamexecutor/lib/unittests/KernelSpecTest.cpp
  streamexecutor/lib/unittests/PackedKernelArgumentArrayTest.cpp
  streamexecutor/lib/unittests/SimpleHostPlatformDevice.h
  streamexecutor/lib/unittests/StreamTest.cpp
  streamexecutor/unittests/CMakeLists.txt
  streamexecutor/unittests/CoreTests/CMakeLists.txt
  streamexecutor/unittests/CoreTests/DeviceTest.cpp
  streamexecutor/unittests/CoreTests/KernelSpecTest.cpp
  streamexecutor/unittests/CoreTests/PackedKernelArgumentArrayTest.cpp
  streamexecutor/unittests/CoreTests/SimpleHostPlatformDevice.h
  streamexecutor/unittests/CoreTests/StreamTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D24368.70768.patch
Type: text/x-patch
Size: 47900 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/parallel_libs-commits/attachments/20160909/8aa285e1/attachment-0001.bin>


More information about the Parallel_libs-commits mailing list