[Parallel_libs-commits] [PATCH] D24302: Add streamexecutor-config

[Jason Henline via Parallel_libs-commits]

jhen added a comment.

In https://reviews.llvm.org/D24302#536448, @jprice wrote:

> Maybe I'm doing something wrong, but the single-quotes wrapping the include/lib paths given by `--cppflags` and `--ldflags` are not working for me. The compiler fails to find the StreamExecutor headers and libraries, and warns that the library directory doesn't exist. It's almost as if the quotes are being taken as part of the paths.
>
> If I manually remove those quotes from the `streamexecutor-config` script then it works fine. It also works if I manually copy the output into the compiler command-line, so maybe there's some weird issue with how the quotes are handled by the shell when substituting command output with `$()`?
>
> Tried on both OS X and Ubuntu, with a trivial program that just includes `StreamExecutor.h`.


I can verify that the quotes are breaking it, and reading through the shell docs shows that the shell doesn't process quotes after command substitution, so I guess the quotes are being passed as literal characters in those arguments. I have an idea of how to fix this, and I should have a patch posted soon.


https://reviews.llvm.org/D24302