[Parallel_libs-commits] [PATCH] D24302: Add streamexecutor-config

Jason Henline via Parallel_libs-commits parallel_libs-commits at lists.llvm.org
Wed Sep 7 11:55:41 PDT 2016


jhen added inline comments.

================
Comment at: streamexecutor/tools/streamexecutor-config/streamexecutor-config.in:155
@@ +154,3 @@
+    all_flags.append(llvm_flags)
+    se_flag = "-I'@CMAKE_INSTALL_PREFIX@/include'"
+    if not has_token(token=se_flag, string=llvm_flags):
----------------
jlebar wrote:
> How does `@CMAKE_INSTALL_PREFIX@` work?  That is, who's responsible for replacing it with an actual path?  From the example in the docstring, it looks like nobody is?
This is a cmake built-in variable that is replaced at build time when this file is configured.

The code in this patch that sets up this configuration is the cmake configure_file command in line 2 in streamexecutor/tools/streamexecutor-config/CMakeLists.txt.


https://reviews.llvm.org/D24302





More information about the Parallel_libs-commits mailing list