[Parallel_libs-commits] [PATCH] D24172: [StreamExecutor] Pass device memory by ref

[Jason Henline via Parallel_libs-commits]

jhen added inline comments.

================
Comment at: streamexecutor/include/streamexecutor/Device.h:223
@@ -222,3 +222,3 @@
   template <typename T>
-  Error synchronousCopyH2D(llvm::ArrayRef<T> Src, GlobalDeviceMemory<T> Dst,
+  Error synchronousCopyH2D(llvm::ArrayRef<T> Src, GlobalDeviceMemory<T> &Dst,
                            size_t ElementCount) {
----------------
Yeah, you're right. It could be confusing. I've changed all the destinations to pass-by-non-const-ref now instead of pass-by-pointer.


https://reviews.llvm.org/D24172