<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, May 17, 2021 at 11:12 AM Krzysztof Parzyszek via cfe-dev <<a href="mailto:cfe-dev@lists.llvm.org">cfe-dev@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">





<div lang="EN-US" style="overflow-wrap: break-word;">
<div class="gmail-m_8924233148030043466WordSection1">
<p class="gmail-m_8924233148030043466MsoPlainText"><span style="font-size:11pt;font-family:Calibri,sans-serif">This is a revision of the previous RFC[1].  This RFC limits the scope to pre-commit reviews only.<u></u><u></u></span></p>
<p class="gmail-m_8924233148030043466MsoPlainText"><span style="font-size:11pt;font-family:Calibri,sans-serif"><u></u> <u></u></span></p>
<p class="gmail-m_8924233148030043466MsoPlainText"><b><span style="font-size:11pt;font-family:Calibri,sans-serif">Statement:<u></u><u></u></span></b></p>
<p class="gmail-m_8924233148030043466MsoPlainText"><span style="font-size:11pt;font-family:Calibri,sans-serif">Our current code review policy states[2]:<u></u><u></u></span></p>
<p class="gmail-m_8924233148030043466MsoPlainText" style="margin-left:0.5in"><span style="font-size:11pt;font-family:Calibri,sans-serif">“Code reviews are conducted, in order of preference, on our web-based code-review tool (see Code Reviews with Phabricator), by email on the relevant
 project’s commit mailing list, on the project’s development list, or on the bug tracker.”<u></u><u></u></span></p>
<p class="gmail-m_8924233148030043466MsoPlainText"><span style="font-size:11pt;font-family:Calibri,sans-serif">This proposal is to limit pre-commit code reviews only to Phabricator.  This would apply to all projects in the LLVM monorepo.  With the change in effect, the amended policy
 would read:<u></u><u></u></span></p>
<p class="gmail-m_8924233148030043466MsoPlainText" style="margin-left:0.5in"><span style="font-size:11pt;font-family:Calibri,sans-serif">“Pre-commit code reviews are conducted on our web-based code-review tool (see Code Reviews with Phabricator). </span></p></div></div></blockquote><div>I'm with you here ^, this seems to document/formalize existing practice - though does this accurately reflect all the projects in the mororepo? I get the impression that mlir, maybe flang, etc might be doing reviews differently? </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div lang="EN-US" style="overflow-wrap: break-word;"><div class="gmail-m_8924233148030043466WordSection1"><p class="gmail-m_8924233148030043466MsoPlainText" style="margin-left:0.5in"><span style="font-size:11pt;font-family:Calibri,sans-serif"> Post-commit reviews are conducted,
 in order of preference, on Phabricator, </span></p></div></div></blockquote><div>This still seems like a change in practice that I'm not in favor of, personally - due to the current divergence between email and phab review feedback. Yes, this would be one way to unify it - but I'm not sure it's necessarily the best one.<br><br>I'd suggest leaving this to a separate proposal so as not to complicate/muddy the waters of the formalization of pre-commit review practice.</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div lang="EN-US" style="overflow-wrap: break-word;"><div class="gmail-m_8924233148030043466WordSection1"><p class="gmail-m_8924233148030043466MsoPlainText" style="margin-left:0.5in"><span style="font-size:11pt;font-family:Calibri,sans-serif">by email on the relevant project’s commit mailing list, on the project’s development list, or on the bug tracker.”<u></u><u></u></span></p>
<p class="gmail-m_8924233148030043466MsoPlainText"><span style="font-size:11pt;font-family:Calibri,sans-serif"><u></u> <u></u></span></p>
<p class="gmail-m_8924233148030043466MsoPlainText"><b><span style="font-size:11pt;font-family:Calibri,sans-serif">Current situation:<u></u><u></u></span></b></p>
<ol style="margin-top:0in" start="1" type="1">
<li class="gmail-m_8924233148030043466MsoPlainText"><span style="font-size:11pt;font-family:Calibri,sans-serif">In a recent llvm-dev thread[3], Christian Kühnel pointed out that pre-commit code reviews rarely originate via an email (most are started
 on Phabricator), although, as others pointed out, email responses to an ongoing review are not uncommon.  (That thread also contains examples of mishaps related to the email-Phabricator interactions, or email handling itself.)<u></u><u></u></span></li><li class="gmail-m_8924233148030043466MsoPlainText"><span style="font-size:11pt;font-family:Calibri,sans-serif">We have Phabricator patches that automatically apply email comments to the Phabricator reviews, although reportedly this functionality is
 not fully reliable[4,5].  This can cause review comments to be lost in the email traffic.<u></u><u></u></span></li></ol>
<p class="gmail-m_8924233148030043466MsoPlainText"><span style="font-size:11pt;font-family:Calibri,sans-serif"><u></u> <u></u></span></p>
<p class="gmail-m_8924233148030043466MsoPlainText"><b><span style="font-size:11pt;font-family:Calibri,sans-serif">Benefits:<u></u><u></u></span></b></p>
<ol style="margin-top:0in" start="1" type="1">
<li class="gmail-m_8924233148030043466MsoPlainText"><span style="font-size:11pt;font-family:Calibri,sans-serif">Single way of doing pre-commit code reviews: these code reviews are a key part of the development process, and having one way of performing
 them would make the process clearer and unambiguous.<u></u><u></u></span></li><li class="gmail-m_8924233148030043466MsoPlainText"><span style="font-size:11pt;font-family:Calibri,sans-serif">Review authors and reviewers would only need to monitor one source of comments without the fear that a review comment may end up overlooked.<u></u><u></u></span></li><li class="gmail-m_8924233148030043466MsoPlainText"><span style="font-size:11pt;font-family:Calibri,sans-serif">This change</span><span style="font-size:11pt;font-family:Calibri,sans-serif"> simply codifies an existing practice.</span><span style="font-size:11pt;font-family:Calibri,sans-serif"><u></u><u></u></span></li></ol>
<p class="gmail-m_8924233148030043466MsoPlainText"><span style="font-size:11pt;font-family:Calibri,sans-serif"><u></u> <u></u></span></p>
<p class="gmail-m_8924233148030043466MsoPlainText"><b><span style="font-size:11pt;font-family:Calibri,sans-serif">Concerns:</span></b><span style="font-size:11pt;font-family:Calibri,sans-serif"><u></u><u></u></span></p>
<ol style="margin-top:0in" start="1" type="1">
<li class="gmail-m_8924233148030043466MsoPlainText"><span style="font-size:11pt;font-family:Calibri,sans-serif">Because of the larger variety, email clients may offer better accessibility options than web browsers.</span><span style="font-size:11pt;font-family:Calibri,sans-serif">
<u></u><u></u></span></li></ol>
<p class="gmail-m_8924233148030043466MsoPlainText"><span style="font-size:11pt;font-family:Calibri,sans-serif"><u></u> <u></u></span></p>
<p class="gmail-m_8924233148030043466MsoPlainText"><span style="font-size:11pt;font-family:Calibri,sans-serif"><u></u> <u></u></span></p>
<p class="gmail-m_8924233148030043466MsoPlainText"><span style="font-size:11pt;font-family:Calibri,sans-serif">[1]
<a href="https://lists.llvm.org/pipermail/llvm-dev/2021-May/150344.html" target="_blank">https://lists.llvm.org/pipermail/llvm-dev/2021-May/150344.html</a><u></u><u></u></span></p>
<p class="gmail-m_8924233148030043466MsoPlainText"><span style="font-size:11pt;font-family:Calibri,sans-serif">[2]
<a href="https://llvm.org/docs/CodeReview.html#what-tools-are-used-for-code-review" target="_blank">
https://llvm.org/docs/CodeReview.html#what-tools-are-used-for-code-review</a><u></u><u></u></span></p>
<p class="gmail-m_8924233148030043466MsoPlainText"><span style="font-size:11pt;font-family:Calibri,sans-serif">[3]
<a href="https://lists.llvm.org/pipermail/llvm-dev/2021-April/150129.html" target="_blank">https://lists.llvm.org/pipermail/llvm-dev/2021-April/150129.html</a><u></u><u></u></span></p>
<p class="gmail-m_8924233148030043466MsoPlainText"><span style="font-size:11pt;font-family:Calibri,sans-serif">[4]
<a href="https://lists.llvm.org/pipermail/llvm-dev/2021-April/150136.html" target="_blank">https://lists.llvm.org/pipermail/llvm-dev/2021-April/150136.html</a><u></u><u></u></span></p>
<p class="gmail-m_8924233148030043466MsoPlainText"><span style="font-size:11pt;font-family:Calibri,sans-serif">[5]
<a href="https://lists.llvm.org/pipermail/llvm-dev/2021-April/150139.html" target="_blank">https://lists.llvm.org/pipermail/llvm-dev/2021-April/150139.html</a><u></u><u></u></span></p>
<p class="gmail-m_8924233148030043466MsoPlainText"><span style="font-size:11pt;font-family:Calibri,sans-serif"><u></u> <u></u></span></p>
<p class="gmail-m_8924233148030043466MsoPlainText"><u></u> <u></u></p>
<p class="gmail-m_8924233148030043466MsoPlainText">-- <u></u><u></u></p>
<p class="gmail-m_8924233148030043466MsoPlainText">Krzysztof Parzyszek  <a href="mailto:kparzysz@quicinc.com" target="_blank">
kparzysz@quicinc.com</a>   AI tools development<u></u><u></u></p>
<p class="gmail-m_8924233148030043466MsoPlainText"><u></u> <u></u></p>
</div>
</div>

_______________________________________________<br>
cfe-dev mailing list<br>
<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev</a><br>
</blockquote></div></div>