<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
I pushed a fixed and submitted a bug report <a href="https://bugs.llvm.org/show_bug.cgi?id=49539" id="LPlnk246863">https://bugs.llvm.org/show_bug.cgi?id=49539</a>. Anyone who was using Clang 12.x or 13.x for offloading applications will most likely need to
recompile.</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Openmp-dev <openmp-dev-bounces@lists.llvm.org> on behalf of Deepak Eachempati via Openmp-dev <openmp-dev@lists.llvm.org><br>
<b>Sent:</b> Monday, March 8, 2021 5:25 PM<br>
<b>To:</b> openmp-dev@lists.llvm.org <openmp-dev@lists.llvm.org><br>
<b>Subject:</b> [EXTERNAL] [Openmp-dev] accidental interface change for __kmpc_push_target_tripcount?</font>
<div> </div>
</div>
<style>
<!--
@font-face
{font-family:"Cambria Math"}
@font-face
{font-family:Calibri}
p.x_MsoNormal, li.x_MsoNormal, div.x_MsoNormal
{margin:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif}
a:link, span.x_MsoHyperlink
{color:#0563C1;
text-decoration:underline}
span.x_EmailStyle17
{font-family:"Calibri",sans-serif;
color:windowtext}
.x_MsoChpDefault
{font-family:"Calibri",sans-serif}
@page WordSection1
{margin:1.0in 1.0in 1.0in 1.0in}
div.x_WordSection1
{}
-->
</style>
<div lang="EN-US" link="#0563C1" vlink="#954F72" style="word-wrap:break-word">
<div class="x_WordSection1">
<p class="x_MsoNormal">Hi,</p>
<p class="x_MsoNormal"> </p>
<p class="x_MsoNormal">It looks like we broke backwards compatibility for the __kmpc_push_target_tripcount with this change that added location fields to libomptarget for debugging:</p>
<p class="x_MsoNormal"> </p>
<p class="x_MsoNormal"><a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D87946&d=DwMFAg&c=C5b8zRQO1miGmBeVZ2LFWg&r=Bh22sFI6-VGL2UQadI-dH9OCPAYb99YwOEfNc6F-8oM&m=SyOKtEnH3HhBUfOSnL8HmCuVsRpPnKnAR1mvsAZUBQs&s=opcC_EdBFuDypMkCLTeZ5VMPwpNPovZy0IpkZivJ7IQ&e=">https://reviews.llvm.org/D87946</a></p>
<p class="x_MsoNormal"> </p>
<p class="x_MsoNormal">From the discussion in the patch review, a suffix (like _loc) was not added for the new Mapper API entry points because they weren’t released in Clang 11.x. But __kmpc_push_target_tripcount was an existing entry point. I suspect this
was just overlooked?</p>
<p class="x_MsoNormal"> </p>
<p class="x_MsoNormal">Do we have time to get this fixed for Clang 12.x, by adding a new __kmpc_push_target_tripcount_loc?</p>
<p class="x_MsoNormal"> </p>
<p class="x_MsoNormal">Thanks,</p>
<p class="x_MsoNormal">Deepak</p>
<p class="x_MsoNormal"> </p>
</div>
</div>
</body>
</html>