<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p><br>
</p>
<div class="moz-cite-prefix">On 10/16/19 5:51 PM, Mehdi AMINI via
llvm-dev wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CANF-O=ZD09fwD=BuW3KBY3kNbckLPGc1Xz2uY0qCQ7gWrmii9g@mail.gmail.com">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr"><br>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Wed, Oct 16, 2019 at
5:46 PM Tom Stellard <<a
href="mailto:tstellar@redhat.com" moz-do-not-send="true">tstellar@redhat.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">On
10/16/2019 07:23 AM, Robinson, Paul wrote:<br>
> +1. And put it in the email (subject?). While it’s
possible to derive a count from a hash manually, better to
have it in the email in the first place. You can’t rely
on order-of-email-delivery to reflect order-of-commit.<br>
> <br>
<br>
I spent some time today looking into what it would take to
add the commit<br>
number into the email. Implementing this will add some
extra complexity to the<br>
emailer script and add another point of failure for us.
We also<br>
can't guarantee to always have it since at some point we
may want to start using<br>
github's standard commit emails.<br>
<br>
I think we should just wait and see how things go without
having <br>
a commit number in the email. It's easy to generate the
number<br>
locally from a git hash if needed. If it becomes a major
inconvenience<br>
to not have it in the email, we can always look at adding
it in later.<br>
</blockquote>
<div><br>
</div>
<div>Having to get an up-to-date local clone and run
commands to be able to reason about the logical
relationship between commits (does this build failure
email from a slow bot comes from before or after I landed
my revert?) seems to me like a non-trivial workflow
regression. I would personally be OK to increase the
tooling complexity to preserve this.</div>
</div>
</div>
</div>
</blockquote>
+1 on this, but it's worth clarifying this is definitely not a
blocker. Just a nice to have which can easily be done after the
switch if needed. <br>
<blockquote type="cite"
cite="mid:CANF-O=ZD09fwD=BuW3KBY3kNbckLPGc1Xz2uY0qCQ7gWrmii9g@mail.gmail.com">
<div dir="ltr">
<div dir="ltr">
<div class="gmail_quote">
<div><br>
</div>
<div>The best way to prove or disprove this is likely do
what you suggest though, and live through this for some
time :)</div>
<div><br>
</div>
<div>-- </div>
<div>Mehdi</div>
<div><br>
</div>
<div><br>
</div>
<div><br>
</div>
<div> </div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><br>
-Tom<br>
<br>
> --paulr<br>
> <br>
> <br>
> <br>
> *From:* llvm-dev <<a
href="mailto:llvm-dev-bounces@lists.llvm.org"
target="_blank" moz-do-not-send="true">llvm-dev-bounces@lists.llvm.org</a>>
*On Behalf Of *Shoaib Meenai via llvm-dev<br>
> *Sent:* Wednesday, October 16, 2019 1:42 AM<br>
> *To:* <a href="mailto:tstellar@redhat.com"
target="_blank" moz-do-not-send="true">tstellar@redhat.com</a>;
Mehdi AMINI <<a href="mailto:joker.eph@gmail.com"
target="_blank" moz-do-not-send="true">joker.eph@gmail.com</a>><br>
> *Cc:* llvm-dev <<a
href="mailto:llvm-dev@lists.llvm.org" target="_blank"
moz-do-not-send="true">llvm-dev@lists.llvm.org</a>>;
cfe-dev <<a href="mailto:cfe-dev@lists.llvm.org"
target="_blank" moz-do-not-send="true">cfe-dev@lists.llvm.org</a>>;
openmp-dev (<a href="mailto:openmp-dev@lists.llvm.org"
target="_blank" moz-do-not-send="true">openmp-dev@lists.llvm.org</a>)
<<a href="mailto:openmp-dev@lists.llvm.org"
target="_blank" moz-do-not-send="true">openmp-dev@lists.llvm.org</a>>;
LLDB Dev <<a href="mailto:lldb-dev@lists.llvm.org"
target="_blank" moz-do-not-send="true">lldb-dev@lists.llvm.org</a>><br>
> *Subject:* Re: [llvm-dev] [cfe-dev] Mailing list
changes this week<br>
> <br>
> <br>
> <br>
> I thought we were just going to count commits on a
particular branch and use the (branch name, commit count)
tuple as our monotonic incrementing identifier? <a
href="https://llvm.org/docs/Proposals/GitHubMove.html#on-managing-revision-numbers-with-git"
rel="noreferrer" target="_blank" moz-do-not-send="true">https://llvm.org/docs/Proposals/GitHubMove.html#on-managing-revision-numbers-with-git</a><br>
> <br>
> <br>
> <br>
> <br>
> <br>
> *From: *cfe-dev <<a
href="mailto:cfe-dev-bounces@lists.llvm.org"
target="_blank" moz-do-not-send="true">cfe-dev-bounces@lists.llvm.org</a>
<mailto:<a href="mailto:cfe-dev-bounces@lists.llvm.org"
target="_blank" moz-do-not-send="true">cfe-dev-bounces@lists.llvm.org</a>>>
on behalf of cfe-dev <<a
href="mailto:cfe-dev@lists.llvm.org" target="_blank"
moz-do-not-send="true">cfe-dev@lists.llvm.org</a>
<mailto:<a href="mailto:cfe-dev@lists.llvm.org"
target="_blank" moz-do-not-send="true">cfe-dev@lists.llvm.org</a>>><br>
> *Organization: *Red Hat<br>
> *Reply-To: *"<a href="mailto:tstellar@redhat.com"
target="_blank" moz-do-not-send="true">tstellar@redhat.com</a>
<mailto:<a href="mailto:tstellar@redhat.com"
target="_blank" moz-do-not-send="true">tstellar@redhat.com</a>>"
<<a href="mailto:tstellar@redhat.com" target="_blank"
moz-do-not-send="true">tstellar@redhat.com</a>
<mailto:<a href="mailto:tstellar@redhat.com"
target="_blank" moz-do-not-send="true">tstellar@redhat.com</a>>><br>
> *Date: *Tuesday, October 15, 2019 at 10:13 PM<br>
> *To: *Mehdi AMINI <<a
href="mailto:joker.eph@gmail.com" target="_blank"
moz-do-not-send="true">joker.eph@gmail.com</a>
<mailto:<a href="mailto:joker.eph@gmail.com"
target="_blank" moz-do-not-send="true">joker.eph@gmail.com</a>>><br>
> *Cc: *llvm-dev <<a
href="mailto:llvm-dev@lists.llvm.org" target="_blank"
moz-do-not-send="true">llvm-dev@lists.llvm.org</a>
<mailto:<a href="mailto:llvm-dev@lists.llvm.org"
target="_blank" moz-do-not-send="true">llvm-dev@lists.llvm.org</a>>>,
cfe-dev <<a href="mailto:cfe-dev@lists.llvm.org"
target="_blank" moz-do-not-send="true">cfe-dev@lists.llvm.org</a>
<mailto:<a href="mailto:cfe-dev@lists.llvm.org"
target="_blank" moz-do-not-send="true">cfe-dev@lists.llvm.org</a>>>,
"openmp-dev (<a href="mailto:openmp-dev@lists.llvm.org"
target="_blank" moz-do-not-send="true">openmp-dev@lists.llvm.org</a>
<mailto:<a href="mailto:openmp-dev@lists.llvm.org"
target="_blank" moz-do-not-send="true">openmp-dev@lists.llvm.org</a>>)"
<<a href="mailto:openmp-dev@lists.llvm.org"
target="_blank" moz-do-not-send="true">openmp-dev@lists.llvm.org</a>
<mailto:<a href="mailto:openmp-dev@lists.llvm.org"
target="_blank" moz-do-not-send="true">openmp-dev@lists.llvm.org</a>>>,
LLDB Dev <<a href="mailto:lldb-dev@lists.llvm.org"
target="_blank" moz-do-not-send="true">lldb-dev@lists.llvm.org</a>
<mailto:<a href="mailto:lldb-dev@lists.llvm.org"
target="_blank" moz-do-not-send="true">lldb-dev@lists.llvm.org</a>>><br>
> *Subject: *Re: [cfe-dev] Mailing list changes this
week<br>
> <br>
> <br>
> <br>
> On 10/15/2019 09:44 PM, Mehdi AMINI wrote:<br>
> <br>
> On Tue, Oct 15, 2019 at 9:33 PM Tom Stellard <<a
href="mailto:tstellar@redhat.com" target="_blank"
moz-do-not-send="true">tstellar@redhat.com</a>
<mailto:<a href="mailto:tstellar@redhat.com"
target="_blank" moz-do-not-send="true">tstellar@redhat.com</a>>
<mailto:<a href="mailto:tstellar@redhat.com"
target="_blank" moz-do-not-send="true">tstellar@redhat.com</a>>
<mailto:<a href="mailto:tstellar@redhat.com"
target="_blank" moz-do-not-send="true">tstellar@redhat.com</a>%3e>>
wrote:<br>
> <br>
> On 10/15/2019 09:24 PM, Mehdi AMINI wrote:<br>
> <br>
> > Hi Tom.<br>
> <br>
> ><br>
> <br>
> > One issue with this is that we don't
have a clear "ordering" from linear revision numbers from
these emails. Have we looked into continuing to generate
our own emails per commits instead so that we control the
format?<br>
> <br>
> ><br>
> <br>
> This actually what we are doing, we are
listening for github commit events and<br>
> <br>
> then generating our own emails based on the
data in the event. We can format<br>
> <br>
> the emails how ever we want, and we tried to
match the current SVN format exactly.<br>
> <br>
> Ah great!<br>
> <br>
> <br>
> <br>
> Is the some other information you would like
to have in the emails to show the<br>
> <br>
> ordering?<br>
> <br>
> The only thing I was looking to get was to
continue to have a monotonic incrementing integer for the
revision instead of the git hash alone: I don't know if
`git llvm` has this feature yet but this was discussed a
while ago (I don't remember if we just mentioned counting
the commits in the repo from the beginning or using an
invocation of `git describe` or something derived).<br>
> <br>
> <br>
> <br>
> We talked about using `git describe` for this, but
this would require that we<br>
> <br>
> add tags to the master branch each time the version
number was bumped. We<br>
> <br>
> discussed this[1] last year, but deferred the
decision, since we couldn't get<br>
> <br>
> consensus on the tag name.<br>
> <br>
> <br>
> <br>
> -Tom<br>
> <br>
> <br>
> <br>
> [1] <a
href="https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.llvm.org_pipermail_llvm-2Ddev_2018-2DDecember_128484.html&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=_SmpuqSzuAhMoF3exJmWRp6KnerIOE6WdU4kcv3tjhQ&s=p_75z-WV3dFcBRoqs2YeTexKxeCf8oyS-atIo6wG6Fg&e="
rel="noreferrer" target="_blank" moz-do-not-send="true">https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.llvm.org_pipermail_llvm-2Ddev_2018-2DDecember_128484.html&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=_SmpuqSzuAhMoF3exJmWRp6KnerIOE6WdU4kcv3tjhQ&s=p_75z-WV3dFcBRoqs2YeTexKxeCf8oyS-atIo6wG6Fg&e=</a><br>
> <br>
> <br>
> <br>
> -- <br>
> <br>
> Mehdi<br>
> <br>
> <br>
> <br>
> -Tom<br>
> <br>
> > Thanks,<br>
> <br>
> ><br>
> <br>
> > --<br>
> <br>
> > Mehdi<br>
> <br>
> ><br>
> <br>
> ><br>
> <br>
> ><br>
> <br>
> > On Tue, Oct 15, 2019 at 9:07 PM Tom
Stellard via cfe-dev <<a
href="mailto:cfe-dev@lists.llvm.org" target="_blank"
moz-do-not-send="true">cfe-dev@lists.llvm.org</a>
<mailto:<a href="mailto:cfe-dev@lists.llvm.org"
target="_blank" moz-do-not-send="true">cfe-dev@lists.llvm.org</a>>
<mailto:<a href="mailto:cfe-dev@lists.llvm.org"
target="_blank" moz-do-not-send="true">cfe-dev@lists.llvm.org</a>>
<mailto:<a href="mailto:cfe-dev@lists.llvm.org"
target="_blank" moz-do-not-send="true">cfe-dev@lists.llvm.org</a>
<mailto:<a href="mailto:cfe-dev@lists.llvm.org"
target="_blank" moz-do-not-send="true">cfe-dev@lists.llvm.org</a>>>
<mailto:<a href="mailto:cfe-dev@lists.llvm.org"
target="_blank" moz-do-not-send="true">cfe-dev@lists.llvm.org</a>%3e%3e>>
wrote:<br>
> <br>
> ><br>
> <br>
> > Hi,<br>
> <br>
> ><br>
> <br>
> > We are going to start to switching
from SVN commit emails to GitHub commit<br>
> <br>
> > emails this week. The only real
change you should notice is that<br>
> <br>
> > the revision number in the subject
will be replaced with a git hash and<br>
> <br>
> > the diff links in the email will
point to GitHub. Otherwise the<br>
> <br>
> > content and format of the email
should be the same.<br>
> <br>
> ><br>
> <br>
> > We are going to start by rolling
this out for the openmp-commits list<br>
> <br>
> > and then once that's working begin
migrating the rest of the lists. If you<br>
> <br>
> > notice any issues with the new
emails, please file a bug and mark it<br>
> <br>
> > as a blocker of the github meta-bug
(<a href="http://llvm.org/PR39393" rel="noreferrer"
target="_blank" moz-do-not-send="true">llvm.org/PR39393</a>
<<a
href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_PR39393&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=_SmpuqSzuAhMoF3exJmWRp6KnerIOE6WdU4kcv3tjhQ&s=eX8PTSE7QycIi5KeESJj4VzteOcs9k7RANSWPgiiQ2Q&e="
rel="noreferrer" target="_blank" moz-do-not-send="true">https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_PR39393&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=_SmpuqSzuAhMoF3exJmWRp6KnerIOE6WdU4kcv3tjhQ&s=eX8PTSE7QycIi5KeESJj4VzteOcs9k7RANSWPgiiQ2Q&e=</a>
> <<a
href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_PR39393&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=_SmpuqSzuAhMoF3exJmWRp6KnerIOE6WdU4kcv3tjhQ&s=eX8PTSE7QycIi5KeESJj4VzteOcs9k7RANSWPgiiQ2Q&e="
rel="noreferrer" target="_blank" moz-do-not-send="true">https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_PR39393&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=_SmpuqSzuAhMoF3exJmWRp6KnerIOE6WdU4kcv3tjhQ&s=eX8PTSE7QycIi5KeESJj4VzteOcs9k7RANSWPgiiQ2Q&e=</a>
>).<br>
> <br>
> ><br>
> <br>
> > Thanks,<br>
> <br>
> > Tom<br>
> <br>
> >
_______________________________________________<br>
> <br>
> > cfe-dev mailing list<br>
> <br>
> > <a
href="mailto:cfe-dev@lists.llvm.org" target="_blank"
moz-do-not-send="true">cfe-dev@lists.llvm.org</a>
<mailto:<a href="mailto:cfe-dev@lists.llvm.org"
target="_blank" moz-do-not-send="true">cfe-dev@lists.llvm.org</a>>
<mailto:<a href="mailto:cfe-dev@lists.llvm.org"
target="_blank" moz-do-not-send="true">cfe-dev@lists.llvm.org</a>>
<mailto:<a href="mailto:cfe-dev@lists.llvm.org"
target="_blank" moz-do-not-send="true">cfe-dev@lists.llvm.org</a>
<mailto:<a href="mailto:cfe-dev@lists.llvm.org"
target="_blank" moz-do-not-send="true">cfe-dev@lists.llvm.org</a>>
<mailto:<a href="mailto:cfe-dev@lists.llvm.org"
target="_blank" moz-do-not-send="true">cfe-dev@lists.llvm.org</a>%3e>><br>
> <br>
> > <a
href="https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_cfe-2Ddev&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=_SmpuqSzuAhMoF3exJmWRp6KnerIOE6WdU4kcv3tjhQ&s=xRFk9gEi6pLejTNAvlPR6gtikLoWNgyvL7b-TAvUcnc&e="
rel="noreferrer" target="_blank" moz-do-not-send="true">https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_cfe-2Ddev&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=_SmpuqSzuAhMoF3exJmWRp6KnerIOE6WdU4kcv3tjhQ&s=xRFk9gEi6pLejTNAvlPR6gtikLoWNgyvL7b-TAvUcnc&e=</a><br>
> <br>
> ><br>
> <br>
> <br>
> <br>
> _______________________________________________<br>
> <br>
> cfe-dev mailing list<br>
> <br>
> <a href="mailto:cfe-dev@lists.llvm.org"
target="_blank" moz-do-not-send="true">cfe-dev@lists.llvm.org</a>
<mailto:<a href="mailto:cfe-dev@lists.llvm.org"
target="_blank" moz-do-not-send="true">cfe-dev@lists.llvm.org</a>><br>
> <br>
> <a
href="https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_cfe-2Ddev&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=_SmpuqSzuAhMoF3exJmWRp6KnerIOE6WdU4kcv3tjhQ&s=xRFk9gEi6pLejTNAvlPR6gtikLoWNgyvL7b-TAvUcnc&e="
rel="noreferrer" target="_blank" moz-do-not-send="true">https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_cfe-2Ddev&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=_SmpuqSzuAhMoF3exJmWRp6KnerIOE6WdU4kcv3tjhQ&s=xRFk9gEi6pLejTNAvlPR6gtikLoWNgyvL7b-TAvUcnc&e=</a><br>
> <br>
> <br>
> <br>
<br>
</blockquote>
</div>
</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<pre class="moz-quote-pre" wrap="">_______________________________________________
LLVM Developers mailing list
<a class="moz-txt-link-abbreviated" href="mailto:llvm-dev@lists.llvm.org">llvm-dev@lists.llvm.org</a>
<a class="moz-txt-link-freetext" href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a>
</pre>
</blockquote>
</body>
</html>