<div dir="ltr">My opinion should be given very low weight but this sounds like a great plan.<div><br></div><div>Jeff</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Feb 6, 2019 at 11:13 AM Wilmarth, Terry L via Openmp-dev <<a href="mailto:openmp-dev@lists.llvm.org">openmp-dev@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div lang="EN-US">
<div class="gmail-m_-6878747602680693119WordSection1">
<p class="MsoNormal">Hello, <u></u><u></u></p>
<p class="MsoNormal">We’re considering removing all of the spec versioning in the runtime. This is the set of spec-version-numbered #ifdefs throughout the runtime (such as OMP_40_ENABLED, OMP_45_ENABLED, OMP_50_ENABLED, etc.) that make it possible to build
earlier versions of the runtime that are compliant with a certain spec version, via LIBOMP_OMP_VERSION.
<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">The main reasons to remove this:<u></u><u></u></p>
<p class="gmail-m_-6878747602680693119MsoListParagraph"><u></u><span>1)<span style="font:7pt "Times New Roman"">
</span></span><u></u>No one seems to be using the spec-version builds.<u></u><u></u></p>
<p class="gmail-m_-6878747602680693119MsoListParagraph"><u></u><span>2)<span style="font:7pt "Times New Roman"">
</span></span><u></u>The #ifdefs are often not well-maintained or correctly added.<u></u><u></u></p>
<p class="gmail-m_-6878747602680693119MsoListParagraph"><u></u><span>3)<span style="font:7pt "Times New Roman"">
</span></span><u></u>The #ifdefs add clutter to the source.<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">We’d like to get some feedback on removing this. If we’re generally in agreement that it should be removed, we’ll start work on the cleanup.<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">Thanks!<u></u><u></u></p>
<p class="MsoNormal">Terry<u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:9pt">Terry L. Wilmarth<br>
<a href="mailto:terry.l.wilmarth@intel.com" target="_blank"><span style="color:rgb(5,99,193)">terry.l.wilmarth@intel.com</span></a> 512-362-0530<br>
Intel/Threading Runtimes<u></u><u></u></span></p>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
</div>
_______________________________________________<br>
Openmp-dev mailing list<br>
<a href="mailto:Openmp-dev@lists.llvm.org" target="_blank">Openmp-dev@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/openmp-dev" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/openmp-dev</a><br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature">Jeff Hammond<br><a href="mailto:jeff.science@gmail.com" target="_blank">jeff.science@gmail.com</a><br><a href="http://jeffhammond.github.io/" target="_blank">http://jeffhammond.github.io/</a></div>