<div dir="ltr">For Android, we run CMake from the runtimes subdirectory because CMake fails during try_compile for reasons I mentioned in <a href="https://reviews.llvm.org/D40080" rel="noreferrer" target="_blank" style="font-size:12.8px">https://reviews.llvm.org/D4008<wbr>0</a>.  After adding an empty 'project()' right after the version specification, I can successfully build openmp for Android by running CMake from the top-level .</div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Nov 15, 2017 at 8:22 AM, Jonas Hahnfeld via Openmp-dev <span dir="ltr"><<a href="mailto:openmp-dev@lists.llvm.org" target="_blank">openmp-dev@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">To show what I have in mind, I have just put up three patches that refactors duplicated code:<br>
<a href="https://reviews.llvm.org/D40080" rel="noreferrer" target="_blank">https://reviews.llvm.org/D4008<wbr>0</a>: [CMake] Disallow direct configuration<br>
<a href="https://reviews.llvm.org/D40081" rel="noreferrer" target="_blank">https://reviews.llvm.org/D4008<wbr>1</a>: [CMake] Refactor common settings and flags<br>
<a href="https://reviews.llvm.org/D40082" rel="noreferrer" target="_blank">https://reviews.llvm.org/D4008<wbr>2</a>: [CMake] Refactor testing infrastructure<br>
(Note that all of these delete more lines than they add while preserving or even adding functionality like a common check-openmp target.)<br>
<br>
A fourth patch (<a href="https://reviews.llvm.org/D40083" rel="noreferrer" target="_blank">https://reviews.llvm.org/D400<wbr>83</a>) dynamically detects information about the test compiler. This is used to<br>
1) restrict tests for libomptarget to Clang 6.0.0 and newer, and<br>
2) XFAIL some tests for known (older) versions of the compiler - we'll need more of this for OMPT.<br>
<br>
Please take a look and kindly tell me what you think.<span class="HOEnZb"><font color="#888888"><br>
Jonas</font></span><div class="HOEnZb"><div class="h5"><br>
<br>
Am 2017-11-09 16:52, schrieb Jonas Hahnfeld via Openmp-dev:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi all,<br>
<br>
is anyone directly configuring the subdirectories (runtime/,<br>
libomptarget/) with CMake? That's currently possible but the usual<br>
process (for me) seems to use the root directory that includes<br>
runtime/ and libomptarget/ (if OPENMP_ENABLE_LIBOMPTARGET is set).<br>
<br>
I'm asking because I'd like to eventually deprecate / remove that<br>
support. This would enable us to factor out some common CMake logic,<br>
for example to setup tests. If you rely on that process to work or if<br>
you think that it's important to have, please speak up!<br>
<br>
Regards,<br>
Jonas<br>
______________________________<wbr>_________________<br>
Openmp-dev mailing list<br>
<a href="mailto:Openmp-dev@lists.llvm.org" target="_blank">Openmp-dev@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/openmp-dev" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/openmp-dev</a><br>
</blockquote>
______________________________<wbr>_________________<br>
Openmp-dev mailing list<br>
<a href="mailto:Openmp-dev@lists.llvm.org" target="_blank">Openmp-dev@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/openmp-dev" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/openmp-dev</a><br>
</div></div></blockquote></div><br></div>