<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Aug 8, 2016, at 9:18 AM, Wilmarth, Terry L via Openmp-dev <<a href="mailto:openmp-dev@lists.llvm.org" class="">openmp-dev@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="WordSection1" style="page: WordSection1; font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span style="font-size: 10pt; font-family: Gisha, sans-serif;" class="">Hello,<o:p class=""></o:p></span></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span style="font-size: 10pt; font-family: Gisha, sans-serif;" class="">We are considering the possibility of doing a conversion of the OpenMP runtime code to better comply with the LLVM coding conventions in the mid- to late-September time frame. This would most likely involve running the code through clang-format with the LLVM style option, as well as correcting any other glaring violations of the coding conventions.<o:p class=""></o:p></span></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span style="font-size: 10pt; font-family: Gisha, sans-serif;" class=""><o:p class=""> </o:p></span></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span style="font-size: 10pt; font-family: Gisha, sans-serif;" class="">It would probably *<b class="">not</b>* involve renaming anything to adhere to naming conventions.<o:p class=""></o:p></span></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span style="font-size: 10pt; font-family: Gisha, sans-serif;" class=""><o:p class=""> </o:p></span></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span style="font-size: 10pt; font-family: Gisha, sans-serif;" class="">However, we’ve noted that LLVM’s coding standards document<span class="Apple-converted-space"> </span><a href="http://llvm.org/docs/CodingStandards.html#introduction" style="color: rgb(149, 79, 114); text-decoration: underline;" class=""><span style="color: windowtext;" class="">says the following</span></a>:<o:p class=""></o:p></span></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span style="font-size: 10pt; font-family: Gisha, sans-serif;" class=""><o:p class=""> </o:p></span></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span style="font-size: 10pt; font-family: Gisha, sans-serif;" class="">“<span style="background-color: white; background-position: initial initial; background-repeat: initial initial;" class="">There are some conventions that are not uniformly followed in the code base (e.g. the naming convention). This is because they are relatively new, and a lot of code was written before they were put in place. Our long term goal is for the entire codebase to follow the convention, but we explicitly<span class="apple-converted-space"> </span><em class=""><span style="font-family: Gisha, sans-serif;" class="">do not</span></em><span class="apple-converted-space"> </span>want patches that do large-scale reformating of existing code. On the other hand, it is reasonable to rename the methods of a class if you’re about to change it in some other way. Just do the reformating as a separate commit from the functionality change.</span>“<o:p class=""></o:p></span></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span style="font-size: 10pt; font-family: Gisha, sans-serif;" class=""><o:p class=""> </o:p></span></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span style="font-size: 10pt; font-family: Gisha, sans-serif;" class="">This would definitely be a large-scale reformatting.</span><span style="font-family: Gisha, sans-serif; font-size: 10pt;" class=""> </span></div></div></div></blockquote><br class=""></div><div>Hi Terry,</div><div><br class=""></div><div>I’m thrilled to hear that you’re interested in doing this. FYI, there is an exactly analogous discussion going on in the LLDB space, where they are similarly reformatting the world to make it more consistent with LLVM standards.</div><div><br class=""></div>I think that doing a large scale reformating like this is a great thing to do since it fixes a large problem. My advice is to do it all as one major commit. This way there is one discontinuity in the version control stream, and not lots of little ones everywhere. This is the approach the LLDB community is preferring to take, and I think it is the best approach that gets to the right answer.<div class=""><br class=""></div><div class="">-Chris</div></body></html>