<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=us-ascii"><meta name=Generator content="Microsoft Word 14 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:Gisha;
panose-1:2 11 5 2 4 2 4 2 2 3;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
span.E-MailFormatvorlage17
{mso-style-type:personal;
font-family:"Gisha","sans-serif";
color:windowtext;
font-weight:normal;
font-style:normal;
text-decoration:none none;}
span.apple-converted-space
{mso-style-name:apple-converted-space;}
span.E-MailFormatvorlage20
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body lang=EN-US link="#0563C1" vlink="#954F72"><div class=WordSection1><p class=MsoNormal><span style='color:#1F497D'>Hi Terry,<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>IMO we should for now stay with the current coding standard as it is currently consistently used within the runtime (4 spaces indention, naming etc.).<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>That said, there was a proposal of moving the OpenMP runtime into parallel_libs (which I completely support btw).<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>If the whole code is then recommitted anyway, I think it is safe to do the cleanups in that process.<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>Regards,<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>Jonas<o:p></o:p></span></p><p class=MsoNormal><o:p> </o:p></p><div style='border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt'><div><div style='border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm'><p class=MsoNormal><b><span lang=DE style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'>From:</span></b><span lang=DE style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'> Openmp-dev [mailto:openmp-dev-bounces@lists.llvm.org] <b>On Behalf Of </b>Wilmarth, Terry L via Openmp-dev<br><b>Sent:</b> Monday, August 08, 2016 6:18 PM<br><b>To:</b> openmp-dev@lists.llvm.org<br><b>Subject:</b> [Openmp-dev] LLVM coding conventions an the OpenMP runtime<o:p></o:p></span></p></div></div><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal><span style='font-size:10.0pt;font-family:"Gisha","sans-serif"'>Hello, <o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt;font-family:"Gisha","sans-serif"'>We are considering the possibility of doing a conversion of the OpenMP runtime code to better comply with the LLVM coding conventions in the mid- to late-September time frame. This would most likely involve running the code through clang-format with the LLVM style option, as well as correcting any other glaring violations of the coding conventions.<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt;font-family:"Gisha","sans-serif"'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt;font-family:"Gisha","sans-serif"'>It would probably *<b>not</b>* involve renaming anything to adhere to naming conventions. <o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt;font-family:"Gisha","sans-serif"'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt;font-family:"Gisha","sans-serif"'>However, we’ve noted that LLVM’s coding standards document <a href="http://llvm.org/docs/CodingStandards.html#introduction"><span style='color:windowtext'>says the following</span></a>:<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt;font-family:"Gisha","sans-serif"'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt;font-family:"Gisha","sans-serif"'>“<span style='background:white'>There are some conventions that are not uniformly followed in the code base (e.g. the naming convention). This is because they are relatively new, and a lot of code was written before they were put in place. Our long term goal is for the entire codebase to follow the convention, but we explicitly<span class=apple-converted-space> </span><em><span style='font-family:"Gisha","sans-serif"'>do not</span></em><span class=apple-converted-space> </span>want patches that do large-scale reformating of existing code. On the other hand, it is reasonable to rename the methods of a class if you’re about to change it in some other way. Just do the reformating as a separate commit from the functionality change.</span>“<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt;font-family:"Gisha","sans-serif"'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt;font-family:"Gisha","sans-serif"'>This would definitely be a large-scale reformatting.<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt;font-family:"Gisha","sans-serif"'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt;font-family:"Gisha","sans-serif"'>So I just wanted to get some feedback on this before we make plans to do this.<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt;font-family:"Gisha","sans-serif"'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt;font-family:"Gisha","sans-serif"'>Thanks!<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.0pt;font-family:"Gisha","sans-serif"'>Terry<o:p></o:p></span></p><p class=MsoNormal style='mso-margin-top-alt:auto;mso-margin-bottom-alt:auto'><span style='font-size:8.0pt;font-family:"Gisha","sans-serif"'>--<br>Terry L. Wilmarth<br><a href="mailto:terry.l.wilmarth@intel.com">terry.l.wilmarth@intel.com</a> 217/403-4251<br>Intel/SSG/DPD/TCAR/RAD/Threading Runtimes <o:p></o:p></span></p><p class=MsoNormal><o:p> </o:p></p></div></div></body></html>