<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<!--[if !mso]><style>v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style><![endif]--><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p
{mso-style-priority:99;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Carlo,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Thank you for raising those issues.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">I believe I have fixed those two problems with this updated version of this patch. I could actually test the makefile logic by forcing a compile to ppc64le
and seeing that it was attempting to put it in lin_ppc64le and also CACHE_LINE is 128 again for both ppc64 and ppc64le.
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Andrey,
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">can you commit this?<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">To apply patch:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">$ patch –p0 < ppc64le-support-v3.patch<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">-- Johnny<o:p></o:p></span></p>
<p class="MsoNormal"><a name="_MailEndCompose"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></a></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""> Carlo Bertolli [mailto:cbertol@us.ibm.com]
<br>
<b>Sent:</b> Friday, January 16, 2015 6:33 PM<br>
<b>To:</b> Peyton, Jonathan L<br>
<b>Cc:</b> C Bergström; Cownie, James H; openmp-dev@dcs-maillist2.engr.illinois.edu<br>
<b>Subject:</b> RE: Getting Architecture Patch<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p><span style="font-size:10.0pt;font-family:"Arial","sans-serif"">Hi Jonathan</span><br>
<br>
<span style="font-size:10.0pt;font-family:"Arial","sans-serif"">Thanks for the changes (not sure why they did not show up in the conflict list after git merge).</span><br>
<span style="font-size:10.0pt;font-family:"Arial","sans-serif"">This works for me on both ppc64 and ppc64le.</span><br>
<br>
<span style="font-size:10.0pt;font-family:"Arial","sans-serif"">I noticed some minor changes to be done for ppc64le when using make:</span><br>
<br>
<span style="font-size:10.0pt;font-family:"Arial","sans-serif"">1. CACHE_LINE changes during compilation, from 128 (correct) to 64 (incorrect).</span><br>
<br>
<span style="font-size:10.0pt;font-family:"Arial","sans-serif"">2. The target directory is ppc64 instead of ppc64le.</span><br>
<br>
<span style="font-size:10.0pt;font-family:"Arial","sans-serif"">For now I can live with both, if this is fine by you. I will submit a patch for this later.</span><br>
<br>
<br>
<span style="font-size:10.0pt;font-family:"Arial","sans-serif"">Thanks again</span><br>
<br>
<span style="font-size:10.0pt;font-family:"Arial","sans-serif"">-- Carlo</span><br>
<br>
<br>
<img width="16" height="16" id="_x0000_i1025" src="cid:image001.gif@01D033D9.A4CD6B70" alt="Inactive hide details for "Peyton, Jonathan L" ---01/16/2015 07:01:46 PM---Carlo, I have applied your patch on top of the most "><span style="font-size:10.0pt;font-family:"Arial","sans-serif";color:#424282">"Peyton,
Jonathan L" ---01/16/2015 07:01:46 PM---Carlo, I have applied your patch on top of the most recent changes (Intel® MIC changes), and also ad</span><br>
<br>
<span style="font-size:7.5pt;font-family:"Arial","sans-serif";color:#5F5F5F">From:
</span><span style="font-size:7.5pt;font-family:"Arial","sans-serif"">"Peyton, Jonathan L" <<a href="mailto:jonathan.l.peyton@intel.com">jonathan.l.peyton@intel.com</a>></span><br>
<span style="font-size:7.5pt;font-family:"Arial","sans-serif";color:#5F5F5F">To: </span>
<span style="font-size:7.5pt;font-family:"Arial","sans-serif"">Carlo Bertolli/Watson/IBM@IBMUS, C Bergström <<a href="mailto:cbergstrom@pathscale.com">cbergstrom@pathscale.com</a>></span><br>
<span style="font-size:7.5pt;font-family:"Arial","sans-serif";color:#5F5F5F">Cc: </span>
<span style="font-size:7.5pt;font-family:"Arial","sans-serif"">"Cownie, James H" <<a href="mailto:james.h.cownie@intel.com">james.h.cownie@intel.com</a>>, "<a href="mailto:openmp-dev@dcs-maillist2.engr.illinois.edu">openmp-dev@dcs-maillist2.engr.illinois.edu</a>"
<<a href="mailto:openmp-dev@dcs-maillist2.engr.illinois.edu">openmp-dev@dcs-maillist2.engr.illinois.edu</a>></span><br>
<span style="font-size:7.5pt;font-family:"Arial","sans-serif";color:#5F5F5F">Date:
</span><span style="font-size:7.5pt;font-family:"Arial","sans-serif"">01/16/2015 07:01 PM</span><br>
<span style="font-size:7.5pt;font-family:"Arial","sans-serif";color:#5F5F5F">Subject:
</span><span style="font-size:7.5pt;font-family:"Arial","sans-serif"">RE: Getting Architecture Patch</span><o:p></o:p></p>
<div class="MsoNormal">
<hr size="2" width="100%" noshade="" style="color:#8091A5" align="left">
</div>
<p class="MsoNormal"><br>
<br>
<br>
<span style="font-size:10.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Carlo,</span><br>
<span style="font-size:10.0pt;font-family:"Calibri","sans-serif";color:#1F497D"> </span><br>
<span style="font-size:10.0pt;font-family:"Calibri","sans-serif";color:#1F497D">I have applied your patch on top of the most recent changes (Intel® MIC changes), and also added a few changes:</span><br>
<span style="font-size:10.0pt;font-family:"Calibri","sans-serif";color:#1F497D"> </span><br>
<span style="font-size:10.0pt;font-family:Consolas">diff --git a/runtime/CMakeLists.txt b/runtime/CMakeLists.txt</span><br>
<span style="font-size:10.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Got rid of this deletion of AARCH64</span><br>
<span style="font-size:10.0pt;font-family:Consolas">set(INTEL64 FALSE)</span><br>
<span style="font-size:10.0pt;font-family:Consolas">set(ARM FALSE)</span><br>
<span style="font-size:10.0pt;font-family:Consolas">-set(AARCH64 FALSE)</span><br>
<span style="font-size:10.0pt;font-family:Consolas">+set(PPC64BE FALSE)</span><br>
<span style="font-size:10.0pt;font-family:Consolas">+set(PPC64LE FALSE)</span><br>
<span style="font-size:10.0pt;font-family:"Calibri","sans-serif""> </span><br>
<span style="font-size:10.0pt;font-family:Consolas">diff --git a/runtime/src/kmp_os.h b/runtime/src/kmp_os.h</span><br>
<span style="font-size:10.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Got rid of this deletion of AARCH64</span><br>
<span style="font-size:10.0pt;font-family:Consolas">-#define KMP_ARCH_PPC64 0</span><br>
<span style="font-size:10.0pt;font-family:Consolas">-#define KMP_ARCH_AARCH64 0</span><br>
<span style="font-size:10.0pt;font-family:Consolas">+#define KMP_ARCH_X86_64 0</span><br>
<span style="font-size:10.0pt;font-family:"Calibri","sans-serif""> </span><br>
<span style="font-size:10.0pt;font-family:"Calibri","sans-serif"">In makefile.mk, I added a few places where I feel it should be checking for both ppc64 and ppc64le, you can see this in the attached patch file.</span><br>
<span style="font-size:10.0pt;font-family:"Calibri","sans-serif""> </span><br>
<span style="font-size:10.0pt;font-family:"Calibri","sans-serif"">Check this out and see if it is correct.</span><br>
<span style="font-size:10.0pt;font-family:"Calibri","sans-serif"">To apply the patch on clean updated repository:</span><br>
<span style="font-size:10.0pt;font-family:"Calibri","sans-serif"">$ patch –p0 < ppc64le-support-v2.patch</span><br>
<span style="font-size:10.0pt;font-family:"Calibri","sans-serif""> </span><br>
<span style="font-size:10.0pt;font-family:"Calibri","sans-serif"">-- Johnny</span><br>
<span style="font-size:10.0pt;font-family:"Calibri","sans-serif""> </span><br>
<b><span style="font-size:10.0pt;font-family:"Calibri","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Calibri","sans-serif""> Carlo Bertolli [<a href="mailto:cbertol@us.ibm.com">mailto:cbertol@us.ibm.com</a>]
<b><br>
Sent:</b> Thursday, January 15, 2015 11:00 PM<b><br>
To:</b> C Bergström<b><br>
Cc:</b> Cownie, James H; Peyton, Jonathan L; <a href="mailto:openmp-dev@dcs-maillist2.engr.illinois.edu">
openmp-dev@dcs-maillist2.engr.illinois.edu</a><b><br>
Subject:</b> Re: Getting Architecture Patch</span><br>
<o:p></o:p></p>
<p><span style="font-size:10.0pt;font-family:"Arial","sans-serif"">Hi</span><br>
<span style="font-size:10.0pt;font-family:"Arial","sans-serif""><br>
Did now see that one - I removed it in the attached version. Let me know if I broke something.</span><br>
<br>
<i><br>
(See attached file: ppc64le-support.patch)</i><br>
<span style="font-size:10.0pt;font-family:"Arial","sans-serif""><br>
Thanks</span><br>
<span style="font-size:10.0pt;font-family:"Arial","sans-serif""><br>
-- Carlo</span><br>
<br>
<img border="0" width="16" height="16" id="_x0000_i1027" src="cid:image001.gif@01D033D9.A4CD6B70" alt="Inactive hide details for C Bergström ---01/15/2015 11:53:47 PM---A whitespace change snuck in at here (extra tab) +#define KMP"><span style="font-size:10.0pt;font-family:"Arial","sans-serif";color:#424282">C
Bergström ---01/15/2015 11:53:47 PM---A whitespace change snuck in at here (extra tab) +#define KMP_ARCH_X86_64 0</span><br>
<span style="font-size:7.5pt;font-family:"Arial","sans-serif";color:#5F5F5F"><br>
From: </span><span style="font-size:7.5pt;font-family:"Arial","sans-serif"">C Bergström <</span><a href="mailto:cbergstrom@pathscale.com"><span style="font-size:7.5pt;font-family:"Arial","sans-serif";color:#0563C1">cbergstrom@pathscale.com</span></a><span style="font-size:7.5pt;font-family:"Arial","sans-serif"">><span style="color:#5F5F5F"><br>
To: </span>Carlo Bertolli/Watson/IBM@IBMUS<span style="color:#5F5F5F"><br>
Cc: </span>"Peyton, Jonathan L" <</span><a href="mailto:jonathan.l.peyton@intel.com"><span style="font-size:7.5pt;font-family:"Arial","sans-serif";color:#0563C1">jonathan.l.peyton@intel.com</span></a><span style="font-size:7.5pt;font-family:"Arial","sans-serif"">>,
"Cownie, James H" <</span><a href="mailto:james.h.cownie@intel.com"><span style="font-size:7.5pt;font-family:"Arial","sans-serif";color:#0563C1">james.h.cownie@intel.com</span></a><span style="font-size:7.5pt;font-family:"Arial","sans-serif"">>, "</span><a href="mailto:openmp-dev@dcs-maillist2.engr.illinois.edu"><span style="font-size:7.5pt;font-family:"Arial","sans-serif";color:#0563C1">openmp-dev@dcs-maillist2.engr.illinois.edu</span></a><span style="font-size:7.5pt;font-family:"Arial","sans-serif"">"
<</span><a href="mailto:openmp-dev@dcs-maillist2.engr.illinois.edu"><span style="font-size:7.5pt;font-family:"Arial","sans-serif";color:#0563C1">openmp-dev@dcs-maillist2.engr.illinois.edu</span></a><span style="font-size:7.5pt;font-family:"Arial","sans-serif"">><span style="color:#5F5F5F"><br>
Date: </span>01/15/2015 11:53 PM<span style="color:#5F5F5F"><br>
Subject: </span>Re: Getting Architecture Patch</span><o:p></o:p></p>
<div class="MsoNormal">
<hr size="2" width="100%" noshade="" style="color:#A0A0A0" align="left">
</div>
<p class="MsoNormal"><br>
<br>
<br>
<br>
A whitespace change snuck in at here (extra tab)<br>
<br>
+#define KMP_ARCH_X86_64 0<br>
<br>
Otherwise the patch is probably in align with the intention[attachment "ppc64le-support-v2.patch" deleted by Carlo Bertolli/Watson/IBM]
<o:p></o:p></p>
</div>
</body>
</html>