<html><body>
<p><font size="2" face="sans-serif">Hi Jonathan</font><br>
<br>
<font size="2" face="sans-serif">Thanks for the changes (not sure why they did not show up in the conflict list after git merge).</font><br>
<font size="2" face="sans-serif">This works for me on both ppc64 and ppc64le.</font><br>
<br>
<font size="2" face="sans-serif">I noticed some minor changes to be done for ppc64le when using make:</font><br>
<br>
<font size="2" face="sans-serif">1. CACHE_LINE changes during compilation, from 128 (correct) to 64 (incorrect).</font><br>
<br>
<font size="2" face="sans-serif">2. The target directory is ppc64 instead of ppc64le.</font><br>
<br>
<font size="2" face="sans-serif">For now I can live with both, if this is fine by you. I will submit a patch for this later.</font><br>
<br>
<br>
<font size="2" face="sans-serif">Thanks again</font><br>
<br>
<font size="2" face="sans-serif">-- Carlo</font><br>
<br>
<br>
<img width="16" height="16" src="cid:1__=0ABBF743DF921F068f9e8a93df938@us.ibm.com" border="0" alt="Inactive hide details for "Peyton, Jonathan L" ---01/16/2015 07:01:46 PM---Carlo, I have applied your patch on top of the most "><font size="2" color="#424282" face="sans-serif">"Peyton, Jonathan L" ---01/16/2015 07:01:46 PM---Carlo, I have applied your patch on top of the most recent changes (Intel® MIC changes), and also ad</font><br>
<br>
<font size="1" color="#5F5F5F" face="sans-serif">From: </font><font size="1" face="sans-serif">"Peyton, Jonathan L" <jonathan.l.peyton@intel.com></font><br>
<font size="1" color="#5F5F5F" face="sans-serif">To: </font><font size="1" face="sans-serif">Carlo Bertolli/Watson/IBM@IBMUS, C Bergström <cbergstrom@pathscale.com></font><br>
<font size="1" color="#5F5F5F" face="sans-serif">Cc: </font><font size="1" face="sans-serif">"Cownie, James H" <james.h.cownie@intel.com>, "openmp-dev@dcs-maillist2.engr.illinois.edu" <openmp-dev@dcs-maillist2.engr.illinois.edu></font><br>
<font size="1" color="#5F5F5F" face="sans-serif">Date: </font><font size="1" face="sans-serif">01/16/2015 07:01 PM</font><br>
<font size="1" color="#5F5F5F" face="sans-serif">Subject: </font><font size="1" face="sans-serif">RE: Getting Architecture Patch</font><br>
<hr width="100%" size="2" align="left" noshade style="color:#8091A5; "><br>
<br>
<br>
<font size="2" color="#1F497D" face="Calibri">Carlo,</font><br>
<font size="2" color="#1F497D" face="Calibri"> </font><br>
<font size="2" color="#1F497D" face="Calibri">I have applied your patch on top of the most recent changes (Intel® MIC changes), and also added a few changes:</font><br>
<font size="2" color="#1F497D" face="Calibri"> </font><br>
<font size="2" face="Consolas">diff --git a/runtime/CMakeLists.txt b/runtime/CMakeLists.txt</font><br>
<font size="2" color="#1F497D" face="Calibri">Got rid of this deletion of AARCH64</font><br>
<font size="2" face="Consolas">set(INTEL64 FALSE)</font><br>
<font size="2" face="Consolas">set(ARM FALSE)</font><br>
<font size="2" face="Consolas">-set(AARCH64 FALSE)</font><br>
<font size="2" face="Consolas">+set(PPC64BE FALSE)</font><br>
<font size="2" face="Consolas">+set(PPC64LE FALSE)</font><br>
<a name="_MailEndCompose"></a><font size="2" face="Calibri"> </font><br>
<font size="2" face="Consolas">diff --git a/runtime/src/kmp_os.h b/runtime/src/kmp_os.h</font><br>
<font size="2" color="#1F497D" face="Calibri">Got rid of this deletion of AARCH64</font><br>
<font size="2" face="Consolas">-#define KMP_ARCH_PPC64 0</font><br>
<font size="2" face="Consolas">-#define KMP_ARCH_AARCH64 0</font><br>
<font size="2" face="Consolas">+#define KMP_ARCH_X86_64 0</font><br>
<font size="2" face="Calibri"> </font><br>
<font size="2" face="Calibri">In makefile.mk, I added a few places where I feel it should be checking for both ppc64 and ppc64le, you can see this in the attached patch file.</font><br>
<font size="2" face="Calibri"> </font><br>
<font size="2" face="Calibri">Check this out and see if it is correct.</font><br>
<font size="2" face="Calibri">To apply the patch on clean updated repository:</font><br>
<font size="2" face="Calibri">$ patch –p0 < ppc64le-support-v2.patch</font><br>
<font size="2" face="Calibri"> </font><br>
<font size="2" face="Calibri">-- Johnny</font><br>
<font size="2" face="Calibri"> </font><br>
<font size="2" face="Calibri"><b>From:</b></font><font size="2" face="Calibri"> Carlo Bertolli [</font><font size="2" face="Calibri"><a href="mailto:cbertol@us.ibm.com">mailto:cbertol@us.ibm.com</a></font><font size="2" face="Calibri">] </font><font size="2" face="Calibri"><b><br>
Sent:</b></font><font size="2" face="Calibri"> Thursday, January 15, 2015 11:00 PM</font><font size="2" face="Calibri"><b><br>
To:</b></font><font size="2" face="Calibri"> C Bergström</font><font size="2" face="Calibri"><b><br>
Cc:</b></font><font size="2" face="Calibri"> Cownie, James H; Peyton, Jonathan L; openmp-dev@dcs-maillist2.engr.illinois.edu</font><font size="2" face="Calibri"><b><br>
Subject:</b></font><font size="2" face="Calibri"> Re: Getting Architecture Patch</font><br>
<font size="3" face="Times New Roman"> </font>
<p><font size="2" face="Arial">Hi</font><font size="3" face="Times New Roman"><br>
</font><font size="2" face="Arial"><br>
Did now see that one - I removed it in the attached version. Let me know if I broke something.</font><font size="3" face="Times New Roman"><br>
<br>
</font><font size="3" face="Times New Roman"><i><br>
(See attached file: ppc64le-support.patch)</i></font><font size="3" face="Times New Roman"><br>
</font><font size="2" face="Arial"><br>
Thanks</font><font size="3" face="Times New Roman"><br>
</font><font size="2" face="Arial"><br>
-- Carlo</font><font size="3" face="Times New Roman"><br>
<br>
</font><img src="cid:1__=0ABBF743DF921F068f9e8a93df938@us.ibm.com" width="16" height="16" alt="Inactive hide details for C Bergström ---01/15/2015 11:53:47 PM---A whitespace change snuck in at here (extra tab) +#define KMP"><font size="2" color="#424282" face="Arial">C Bergström ---01/15/2015 11:53:47 PM---A whitespace change snuck in at here (extra tab) +#define KMP_ARCH_X86_64 0</font><font size="3" face="Times New Roman"><br>
</font><font size="1" color="#5F5F5F" face="Arial"><br>
From: </font><font size="1" face="Arial">C Bergström <</font><a href="mailto:cbergstrom@pathscale.com"><font size="1" color="#0563C1" face="Arial"><u>cbergstrom@pathscale.com</u></font></a><font size="1" face="Arial">></font><font size="1" color="#5F5F5F" face="Arial"><br>
To: </font><font size="1" face="Arial">Carlo Bertolli/Watson/IBM@IBMUS</font><font size="1" color="#5F5F5F" face="Arial"><br>
Cc: </font><font size="1" face="Arial">"Peyton, Jonathan L" <</font><a href="mailto:jonathan.l.peyton@intel.com"><font size="1" color="#0563C1" face="Arial"><u>jonathan.l.peyton@intel.com</u></font></a><font size="1" face="Arial">>, "Cownie, James H" <</font><a href="mailto:james.h.cownie@intel.com"><font size="1" color="#0563C1" face="Arial"><u>james.h.cownie@intel.com</u></font></a><font size="1" face="Arial">>, "</font><a href="mailto:openmp-dev@dcs-maillist2.engr.illinois.edu"><font size="1" color="#0563C1" face="Arial"><u>openmp-dev@dcs-maillist2.engr.illinois.edu</u></font></a><font size="1" face="Arial">" <</font><a href="mailto:openmp-dev@dcs-maillist2.engr.illinois.edu"><font size="1" color="#0563C1" face="Arial"><u>openmp-dev@dcs-maillist2.engr.illinois.edu</u></font></a><font size="1" face="Arial">></font><font size="1" color="#5F5F5F" face="Arial"><br>
Date: </font><font size="1" face="Arial">01/15/2015 11:53 PM</font><font size="1" color="#5F5F5F" face="Arial"><br>
Subject: </font><font size="1" face="Arial">Re: Getting Architecture Patch</font><br>
<hr width="100%" size="2" align="left" noshade><br>
<font size="3" face="Times New Roman"><br>
<br>
<br>
A whitespace change snuck in at here (extra tab)<br>
<br>
+#define KMP_ARCH_X86_64 0<br>
<br>
Otherwise the patch is probably in align with the intention[attachment "ppc64le-support-v2.patch" deleted by Carlo Bertolli/Watson/IBM] </font><br>
</body></html>