<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<!--[if !mso]><style>v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style><![endif]--><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Verdana;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p
{mso-style-priority:99;
mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Verdana",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><a name="_MailEndCompose"><span style="font-size:10.0pt;font-family:"Arial",sans-serif">Apologies for this late answer - I had to put this on a side for some time.</span><br>
</a><span lang="EN-GB" style="font-size:10.0pt;font-family:"Verdana",sans-serif;color:#1F497D">No problem, what with SC14 and so on we’ve all been busy!<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-GB" style="font-size:10.0pt;font-family:"Verdana",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Arial",sans-serif">Please let me know of any problem with this.</span><br>
<span lang="EN-GB" style="font-size:10.0pt;font-family:"Verdana",sans-serif;color:#1F497D">You’ve made one change that I don’t like, in that AFAICS you renamed the KMP_ARCH_PPC64 to be KMP_ARCH_PPC.
<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-GB" style="font-size:10.0pt;font-family:"Verdana",sans-serif;color:#1F497D">Unless this really is for both 32 and 64 bit PPCs, I’d like to keep the 64 on there (in case you later do want a 32 bit variant).<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-GB" style="font-size:10.0pt;font-family:"Verdana",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<div>
<p class="MsoNormal"><span lang="EN-GB" style="font-size:10.0pt;font-family:"Verdana",sans-serif;color:#1F497D">-- Jim<br>
<br>
James Cownie <james.h.cownie@intel.com><br>
SSG/DPD/TCAR (Technical Computing, Analyzers and Runtimes)<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-GB" style="font-size:10.0pt;font-family:"Verdana",sans-serif;color:#1F497D">Tel: +44 117 9071438</span><span lang="EN-GB" style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p></o:p></span></p>
</div>
<p class="MsoNormal"><span lang="EN-GB" style="font-size:10.0pt;font-family:"Verdana",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> Carlo Bertolli [mailto:cbertol@us.ibm.com]
<br>
<b>Sent:</b> Wednesday, December 10, 2014 7:54 PM<br>
<b>To:</b> Cownie, James H<br>
<b>Cc:</b> C Bergström; openmp-dev@dcs-maillist2.engr.illinois.edu<br>
<b>Subject:</b> RE: [Openmp-dev] Patch for PPC64LE architecture<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p><span style="font-size:10.0pt;font-family:"Arial",sans-serif">Jim</span><br>
<br>
<span style="font-size:10.0pt;font-family:"Arial",sans-serif">Apologies for this late answer - I had to put this on a side for some time.</span><br>
<br>
<span style="font-size:10.0pt;font-family:"Arial",sans-serif">Attached a new patch from your last commit to the trunk that follows the macro convention you suggested.</span><br>
<br>
<span style="font-size:10.0pt;font-family:"Arial",sans-serif">Please let me know of any problem with this.</span><br>
<br>
<i>(See attached file: ppc64_patch_2)</i><br>
<br>
<span style="font-size:10.0pt;font-family:"Arial",sans-serif">Thanks</span><br>
<br>
<span style="font-size:10.0pt;font-family:"Arial",sans-serif">-- Carlo</span><br>
<br>
<br>
<img width="16" height="16" id="_x0000_i1025" src="cid:image001.gif@01D01854.8511CC40" alt="Inactive hide details for "Cownie, James H" ---10/24/2014 09:32:37 AM---I think it may be worth making the clean-up that Christ"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:#424282">"Cownie,
James H" ---10/24/2014 09:32:37 AM---I think it may be worth making the clean-up that Christopher suggested before we push this, unless t</span><br>
<br>
<span style="font-size:7.5pt;font-family:"Arial",sans-serif;color:#5F5F5F">From: </span>
<span style="font-size:7.5pt;font-family:"Arial",sans-serif">"Cownie, James H" <<a href="mailto:james.h.cownie@intel.com">james.h.cownie@intel.com</a>></span><br>
<span style="font-size:7.5pt;font-family:"Arial",sans-serif;color:#5F5F5F">To: </span>
<span style="font-size:7.5pt;font-family:"Arial",sans-serif">C Bergström <<a href="mailto:cbergstrom@pathscale.com">cbergstrom@pathscale.com</a>>, Carlo Bertolli/Watson/IBM@IBMUS</span><br>
<span style="font-size:7.5pt;font-family:"Arial",sans-serif;color:#5F5F5F">Cc: </span>
<span style="font-size:7.5pt;font-family:"Arial",sans-serif">"<a href="mailto:openmp-dev@dcs-maillist2.engr.illinois.edu">openmp-dev@dcs-maillist2.engr.illinois.edu</a>" <<a href="mailto:openmp-dev@dcs-maillist2.engr.illinois.edu">openmp-dev@dcs-maillist2.engr.illinois.edu</a>></span><br>
<span style="font-size:7.5pt;font-family:"Arial",sans-serif;color:#5F5F5F">Date: </span>
<span style="font-size:7.5pt;font-family:"Arial",sans-serif">10/24/2014 09:32 AM</span><br>
<span style="font-size:7.5pt;font-family:"Arial",sans-serif;color:#5F5F5F">Subject:
</span><span style="font-size:7.5pt;font-family:"Arial",sans-serif">RE: [Openmp-dev] Patch for PPC64LE architecture</span><o:p></o:p></p>
<div class="MsoNormal">
<hr size="2" width="100%" noshade="" style="color:#8091A5" align="left">
</div>
<p class="MsoNormal"><br>
<br>
<br>
<span style="font-size:10.0pt;font-family:"Verdana",sans-serif;color:#1F497D">I think it may be worth making the clean-up that Christopher suggested before we push this, unless there is real urgency here.</span><br>
<span style="font-size:10.0pt;font-family:"Verdana",sans-serif;color:#1F497D"> </span><br>
<span style="font-size:10.0pt;font-family:"Verdana",sans-serif;color:#1F497D">This patch is adding a lot of
</span><br>
<span style="font-size:10.0pt;font-family:"Verdana",sans-serif;color:#1F497D">#if KMP_ARCH_PPC64 || KMP_ARCH_PPC64LE</span><br>
<span style="font-size:10.0pt;font-family:"Verdana",sans-serif;color:#1F497D">and similar changes, which would be unnecessary if we went to the other scheme.</span><br>
<span style="font-size:10.0pt;font-family:"Verdana",sans-serif;color:#1F497D"> </span><br>
<span style="font-size:10.0pt;font-family:"Verdana",sans-serif;color:#1F497D">So you would explicitly define the architecture in the scripts and so on as “ppc64be” or “ppc64le”, and the you would define</span><br>
<span style="font-size:10.0pt;font-family:"Verdana",sans-serif;color:#1F497D">KMP_ARCH_PPC64LE or KMP_ARCH_PPC64BE in the compiler flags and have a
</span><br>
<span style="font-size:10.0pt;font-family:"Verdana",sans-serif;color:#1F497D"> </span><br>
<span style="font-size:10.0pt;font-family:"Verdana",sans-serif;color:#1F497D">#define KMP_ARCH_PPC (KMP_ARCH_PPC64LE || KMP_ARCH_PPC64_BE)</span><br>
<span style="font-size:10.0pt;font-family:"Verdana",sans-serif;color:#1F497D"> </span><br>
<span style="font-size:10.0pt;font-family:"Verdana",sans-serif;color:#1F497D">in an appropriate place.</span><br>
<span style="font-size:10.0pt;font-family:"Verdana",sans-serif;color:#1F497D"> </span><br>
<span style="font-size:10.0pt;font-family:"Verdana",sans-serif;color:#1F497D">Then all the endian insensitive code would need no changes elsewhere.</span><br>
<span style="font-size:10.0pt;font-family:"Verdana",sans-serif;color:#1F497D"> </span><br>
<span style="font-size:10.0pt;font-family:"Verdana",sans-serif;color:#1F497D">I think that could really reduce the number of changes and late rreversions.</span><br>
<span style="font-size:10.0pt;font-family:"Verdana",sans-serif;color:#1F497D"> </span><br>
<span style="font-size:10.0pt;font-family:"Verdana",sans-serif;color:#1F497D">-- Jim<br>
<br>
James Cownie <<a href="mailto:james.h.cownie@intel.com">james.h.cownie@intel.com</a>><br>
SSG/DPD/TCAR (Technical Computing, Analyzers and Runtimes)</span><br>
<span style="font-size:10.0pt;font-family:"Verdana",sans-serif;color:#1F497D">Tel: +44 117 9071438</span><br>
<span style="font-size:10.0pt;font-family:"Verdana",sans-serif;color:#1F497D"> </span><br>
<b><span style="font-size:10.0pt;font-family:"Tahoma",sans-serif">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma",sans-serif"> <a href="mailto:openmp-dev-bounces@cs.uiuc.edu">openmp-dev-bounces@cs.uiuc.edu</a> [<a href="mailto:openmp-dev-bounces@cs.uiuc.edu">mailto:openmp-dev-bounces@cs.uiuc.edu</a>]
<b>On Behalf Of </b>C Bergström<b><br>
Sent:</b> Thursday, October 23, 2014 3:59 PM<b><br>
To:</b> Carlo Bertolli<b><br>
Cc:</b> <a href="mailto:openmp-dev@dcs-maillist2.engr.illinois.edu">openmp-dev@dcs-maillist2.engr.illinois.edu</a><b><br>
Subject:</b> Re: [Openmp-dev] Patch for PPC64LE architecture</span><br>
<br>
It's certainly not critical and a small amount of code churn in the next patch is fine.<br>
<br>
This passes my review if someone wants to push it.<br>
<br>
Thanks<br>
<o:p></o:p></p>
<p>---------------------------------------------------------------------<br>
Intel Corporation (UK) Limited<br>
Registered No. 1134945 (England)<br>
Registered Office: Pipers Way, Swindon SN3 1RJ<br>
VAT No: 860 2173 47 <o:p></o:p></p>
<p>This e-mail and any attachments may contain confidential material for<br>
the sole use of the intended recipient(s). Any review or distribution<br>
by others is strictly prohibited. If you are not the intended<br>
recipient, please contact the sender and delete all copies. <o:p></o:p></p>
</div>
<p>---------------------------------------------------------------------<br>
Intel Corporation (UK) Limited<br>
Registered No. 1134945 (England)<br>
Registered Office: Pipers Way, Swindon SN3 1RJ<br>
VAT No: 860 2173 47</p>
<p>This e-mail and any attachments may contain confidential material for<br>
the sole use of the intended recipient(s). Any review or distribution<br>
by others is strictly prohibited. If you are not the intended<br>
recipient, please contact the sender and delete all copies.</p></body>
</html>