<html><body>
<p><font size="2" face="sans-serif">Jim</font><br>
<br>
<font size="2" face="sans-serif">Apologies for this late answer - I had to put this on a side for some time.</font><br>
<br>
<font size="2" face="sans-serif">Attached a new patch from your last commit to the trunk that follows the macro convention you suggested.</font><br>
<br>
<font size="2" face="sans-serif">Please let me know of any problem with this.</font><br>
<br>
<i>(See attached file: ppc64_patch_2)</i><br>
<br>
<font size="2" face="sans-serif">Thanks</font><br>
<br>
<font size="2" face="sans-serif">-- Carlo</font><br>
<br>
<br>
<img width="16" height="16" src="cid:2__=0ABBF739DFFE80468f9e8a93df938@us.ibm.com" border="0" alt="Inactive hide details for "Cownie, James H" ---10/24/2014 09:32:37 AM---I think it may be worth making the clean-up that Christ"><font size="2" color="#424282" face="sans-serif">"Cownie, James H" ---10/24/2014 09:32:37 AM---I think it may be worth making the clean-up that Christopher suggested before we push this, unless t</font><br>
<br>
<font size="1" color="#5F5F5F" face="sans-serif">From: </font><font size="1" face="sans-serif">"Cownie, James H" <james.h.cownie@intel.com></font><br>
<font size="1" color="#5F5F5F" face="sans-serif">To: </font><font size="1" face="sans-serif">C Bergström <cbergstrom@pathscale.com>, Carlo Bertolli/Watson/IBM@IBMUS</font><br>
<font size="1" color="#5F5F5F" face="sans-serif">Cc: </font><font size="1" face="sans-serif">"openmp-dev@dcs-maillist2.engr.illinois.edu" <openmp-dev@dcs-maillist2.engr.illinois.edu></font><br>
<font size="1" color="#5F5F5F" face="sans-serif">Date: </font><font size="1" face="sans-serif">10/24/2014 09:32 AM</font><br>
<font size="1" color="#5F5F5F" face="sans-serif">Subject: </font><font size="1" face="sans-serif">RE: [Openmp-dev] Patch for PPC64LE architecture</font><br>
<hr width="100%" size="2" align="left" noshade style="color:#8091A5; "><br>
<br>
<br>
<font size="2" color="#1F497D" face="Verdana">I think it may be worth making the clean-up that Christopher suggested before we push this, unless there is real urgency here.</font><br>
<font size="2" color="#1F497D" face="Verdana"> </font><br>
<font size="2" color="#1F497D" face="Verdana">This patch is adding a lot of </font><br>
<font size="2" color="#1F497D" face="Verdana">#if KMP_ARCH_PPC64 || KMP_ARCH_PPC64LE</font><br>
<font size="2" color="#1F497D" face="Verdana">and similar changes, which would be unnecessary if we went to the other scheme.</font><br>
<font size="2" color="#1F497D" face="Verdana"> </font><br>
<font size="2" color="#1F497D" face="Verdana">So you would explicitly define the architecture in the scripts and so on as “ppc64be” or “ppc64le”, and the you would define</font><br>
<font size="2" color="#1F497D" face="Verdana">KMP_ARCH_PPC64LE or KMP_ARCH_PPC64BE in the compiler flags and have a </font><br>
<font size="2" color="#1F497D" face="Verdana"> </font><br>
<font size="2" color="#1F497D" face="Verdana">#define KMP_ARCH_PPC (KMP_ARCH_PPC64LE || KMP_ARCH_PPC64_BE)</font><br>
<font size="2" color="#1F497D" face="Verdana"> </font><br>
<font size="2" color="#1F497D" face="Verdana">in an appropriate place.</font><br>
<font size="2" color="#1F497D" face="Verdana"> </font><br>
<font size="2" color="#1F497D" face="Verdana">Then all the endian insensitive code would need no changes elsewhere.</font><br>
<font size="2" color="#1F497D" face="Verdana"> </font><br>
<font size="2" color="#1F497D" face="Verdana">I think that could really reduce the number of changes and late rreversions.</font><br>
<font size="2" color="#1F497D" face="Verdana"> </font><br>
<font size="2" color="#1F497D" face="Verdana">-- Jim<br>
<br>
James Cownie <james.h.cownie@intel.com><br>
SSG/DPD/TCAR (Technical Computing, Analyzers and Runtimes)</font><br>
<font size="2" color="#1F497D" face="Verdana">Tel: +44 117 9071438</font><br>
<font size="2" color="#1F497D" face="Verdana"> </font><br>
<font size="2" face="Tahoma"><b>From:</b></font><font size="2" face="Tahoma"> openmp-dev-bounces@cs.uiuc.edu [</font><font size="2" face="Tahoma"><a href="mailto:openmp-dev-bounces@cs.uiuc.edu">mailto:openmp-dev-bounces@cs.uiuc.edu</a></font><font size="2" face="Tahoma">] </font><font size="2" face="Tahoma"><b>On Behalf Of </b></font><font size="2" face="Tahoma">C Bergström</font><font size="2" face="Tahoma"><b><br>
Sent:</b></font><font size="2" face="Tahoma"> Thursday, October 23, 2014 3:59 PM</font><font size="2" face="Tahoma"><b><br>
To:</b></font><font size="2" face="Tahoma"> Carlo Bertolli</font><font size="2" face="Tahoma"><b><br>
Cc:</b></font><font size="2" face="Tahoma"> openmp-dev@dcs-maillist2.engr.illinois.edu</font><font size="2" face="Tahoma"><b><br>
Subject:</b></font><font size="2" face="Tahoma"> Re: [Openmp-dev] Patch for PPC64LE architecture</font><br>
<font size="3" face="Times New Roman"> </font><br>
<font size="3" face="Times New Roman">It's certainly not critical and a small amount of code churn in the next patch is fine.</font><br>
<font size="3" face="Times New Roman"> </font><br>
<font size="3" face="Times New Roman">This passes my review if someone wants to push it.</font><br>
<font size="3" face="Times New Roman"> </font><br>
<font size="3" face="Times New Roman">Thanks</font><br>
<font size="3" face="Times New Roman"> </font>
<p><font size="3" face="serif">---------------------------------------------------------------------<br>
Intel Corporation (UK) Limited<br>
Registered No. 1134945 (England)<br>
Registered Office: Pipers Way, Swindon SN3 1RJ<br>
VAT No: 860 2173 47</font>
<p><font size="3" face="serif">This e-mail and any attachments may contain confidential material for<br>
the sole use of the intended recipient(s). Any review or distribution<br>
by others is strictly prohibited. If you are not the intended<br>
recipient, please contact the sender and delete all copies.</font>
<p></body></html>